Merge branch 'development' into feature/TTD-2662/function-add-to-ArrayCombined

get random entry, remove array entry by value, add string to each entry in array, create sort by array key

.gitignore

@@ -3,7 +3,7 @@ node_modules/
 **/composer.lock
 **/vendor/
 tools/
-**/configs/.env
+**/.env
 **/.target
 package-lock.json
 build/

.phive/phars.xml

@@ -1,12 +1,12 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phive xmlns="https://phar.io/phive">
-  <phar name="phpunit" version="~9.6" installed="9.6.34" location="./tools/phpunit" copy="false"/>
+  <phar name="phpunit" version="~9.6" installed="9.6.31" location="./tools/phpunit" copy="false"/>
   <phar name="phpcbf" version="4" installed="4.0.1" location="./tools/phpcbf" copy="false"/>
   <phar name="phpcs" version="4" installed="4.0.1" location="./tools/phpcs" copy="false"/>
-  <phar name="phpstan" version="^2.0" installed="2.2.2" location="./tools/phpstan" copy="false"/>
+  <phar name="phpstan" version="^2.0" installed="2.1.33" location="./tools/phpstan" copy="false"/>
   <phar name="phan" version="^5.4.3" installed="5.5.2" location="./tools/phan" copy="false"/>
   <phar name="psalm" version="^5.26.1" installed="5.26.1" location="./tools/psalm" copy="false"/>
   <phar name="phpdox" version="^0.12.0" installed="0.12.0" location="./tools/phpdox" copy="false"/>
-  <phar name="phpdocumentor" version="^3.4.2" installed="3.10.0" location="./tools/phpDocumentor" copy="false"/>
-  <phar name="php-cs-fixer" version="^3.34.1" installed="3.95.10" location="./tools/php-cs-fixer" copy="false"/>
+  <phar name="phpdocumentor" version="^3.4.2" installed="3.9.1" location="./tools/phpDocumentor" copy="false"/>
+  <phar name="php-cs-fixer" version="^3.34.1" installed="3.92.4" location="./tools/php-cs-fixer" copy="false"/>
 </phive>

4dev/locale/en-admin.po

@@ -8,11 +8,11 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: en.UTF-8 LC_MESSAGES admin\n"
-"Report-Msgid-Bugs-To: webmaster+corelibs-translation@ocex.jp\n"
+"Report-Msgid-Bugs-To: clemens.schwaighofer@egplusww.com\n"
 "POT-Creation-Date: 2018-03-28 10:40+0900\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
-"Last-Translator: clemens.schwaighofer@omc.com\n"
-"Language-Team: Omnicom Content Experiences Japan <webmaster@ocex.jp>\n"
+"Last-Translator: clemens.schwaighofer@egplusww.co\n"
+"Language-Team: E-GRAPHICS COMMUNICATIONS Japan <info.jp@egplusww.com>\n"
 "Language: en\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"

4dev/locale/en-frontend.po

@@ -8,11 +8,11 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: en.UTF-8 LC_MESSAGES frontend\n"
-"Report-Msgid-Bugs-To: webmaster+corelibs-translation@ocex.jp\n"
+"Report-Msgid-Bugs-To: clemens.schwaighofer@egplusww.com\n"
 "POT-Creation-Date: 2018-03-28 10:40+0900\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
-"Last-Translator: clemens.schwaighofer@omc.com\n"
-"Language-Team: Omnicom Content Experiences Japan <webmaster@ocex.jp>\n"
+"Last-Translator: clemens.schwaighofer@egplusww.co\n"
+"Language-Team: E-GRAPHICS COMMUNICATIONS Japan <info.jp@egplusww.com>\n"
 "Language: en\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"

4dev/locale/ja-admin.po

@@ -8,11 +8,11 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: ja.UTF-8 LC_MESSAGES admin\n"
-"Report-Msgid-Bugs-To: webmaster+corelibs-translation@ocex.jp\n"
+"Report-Msgid-Bugs-To: clemens.schwaighofer@egplusww.com\n"
 "POT-Creation-Date: 2018-03-28 10:40+0900\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
-"Last-Translator: clemens.schwaighofer@omc.com\n"
-"Language-Team: Omnicom Content Experiences Japan <webmaster@ocex.jp>\n"
+"Last-Translator: clemens.schwaighofer@egplusww.com\n"
+"Language-Team: E-GRAPHICS COMMUNICATIONS Japan <info.jp@egplusww.com>\n"
 "Language: ja\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"

4dev/locale/ja-frontend.po

@@ -8,11 +8,11 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: ja.UTF-8 LC_MESSAGES frontend\n"
-"Report-Msgid-Bugs-To: webmaster+corelibs-translation@ocex.jp\n"
+"Report-Msgid-Bugs-To: clemens.schwaighofer@egplusww.com\n"
 "POT-Creation-Date: 2018-03-28 10:40+0900\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
-"Last-Translator: clemens.schwaighofer@omc.com\n"
-"Language-Team: Omnicom Content Experiences Japan <webmaster@ocex.jp>\n"
+"Last-Translator: clemens.schwaighofer@egplusww.com\n"
+"Language-Team: E-GRAPHICS COMMUNICATIONS Japan <info.jp@egplusww.com>\n"
 "Language: ja\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"

4dev/tests/Convert/CoreLibsConvertJsonTest.php

@@ -277,38 +277,6 @@ final class CoreLibsConvertJsonTest extends TestCase
 		);
 	}
 
-	/**
-	 * Check if invalid flag throws exception
-	 *
-	 * @covers ::jsonValidate
-	 * @testdox jsonValidate test exception thrown on invalid flag
-	 *
-	 * @return void
-	 */
-	public function testJsonValidateInvalidFlag(): void
-	{
-		$this->expectException("\InvalidArgumentException");
-		\CoreLibs\Convert\Json::jsonValidate('{"valid": "json"}', 5);
-	}
-
-	/**
-	 * Check if valid flag throws no exception
-	 *
-	 * @covers ::jsonValidate
-	 * @testdox jsonValidate test no exception on valid flag
-	 *
-	 * @return void
-	 */
-	public function testJsonValidateValidflag(): void
-	{
-		$this->assertTrue(
-			\CoreLibs\Convert\Json::jsonValidate('{"valid": "json"}', 0)
-		);
-		$this->assertTrue(
-			\CoreLibs\Convert\Json::jsonValidate('{"valid": "json"}', JSON_INVALID_UTF8_IGNORE)
-		);
-	}
-
 	/**
 	 * Undocumented function
 	 *

4dev/tests/Get/dotenv/.env

@@ -1 +0,0 @@
-test.env

www/admin/class_test.file.php

@@ -38,25 +38,6 @@ print "GETFILENAMEENDING: $file: " . File::getFilenameEnding($file) . "<br>";
 $file = getcwd() . DIRECTORY_SEPARATOR . 'class_test.file.php';
 print "GETLINESFROMFILE: $file: " . File::getLinesFromFile($file) . "<br>";
 print "MIMEINFO: $file: " . File::getMimeType($file) . "<br>";
-try {
-	print "MIMEINFO: does_not_exists.txt " . File::getMimeType("does_not_exists.txt") . "<br>";
-} catch (\Exception $e) {
-	print "Error: " . get_class($e) . ": " . $e->getMessage() . "<br>";
-}
-
-$files = [
-	'layout/css/edit.css',
-	'layout/javascript/edit.jq.js',
-	'class_test.file.php',
-	getcwd() . DIRECTORY_SEPARATOR . 'class_test.file.php',
-];
-foreach ($files as $file) {
-	try {
-		print "MIMEINFO: $file: " . File::getMimeType($file) . "<br>";
-	} catch (\Exception $e) {
-		print "Error: " . get_class($e) . ": " . $e->getMessage() . "<br>";
-	}
-}
 
 print "</body></html>";
 

www/admin/layout/javascript/edit.jq.js

@@ -1598,17 +1598,4 @@ function createNavMenu(nav_menu, header_id = 'mainHeader') // eslint-disable-lin
 	}
 }
 
-/**
- * HTML decode &something; entrie
- * @param {string} str
- * @returns string
- * @deprecated use utils.js
- */
-function decodeHtmlEntities(str) // eslint-disable-line no-unused-vars
-{
-	const parser = new DOMParser();
-	const doc = parser.parseFromString(str, 'text/html');
-	return doc.documentElement.textContent;
-}
-
 /* END */

www/admin/layout/javascript/utils.js

@@ -135,7 +135,7 @@ var HtmlElementCreator = class {
    * @param  {String} tag          must set tag (div, span, etc)
    * @param  {String} [id='']      optional set for id, if input, select will be used for name
    * @param  {String} [content=''] text content inside, is skipped if sub elements exist
-   * @param  {Array<String>}  [css=[]]     array for css tags
+   * @param  {Array}  [css=[]]     array for css tags
    * @param  {Object} [options={}] anything else (value, placeholder, OnClick, style)
    * @return {Object}              created element as an object
    */
@@ -509,11 +509,6 @@ function numberWithCommas(number) {
 function convertLBtoBR(string) {
   return string.replace(/(?:\r\n|\r|\n)/g, "<br>");
 }
-function decodeHtmlEntities(str) {
-  const parser = new DOMParser();
-  const doc = parser.parseFromString(str, "text/html");
-  return doc.documentElement.textContent;
-}
 
 // src/utils/DateTimeHelpers.mjs
 function getTimestamp() {
@@ -665,19 +660,18 @@ function getQueryStringParam(search = "", query = "", single = false) {
   if (search) {
     let _params = url.searchParams.getAll(search);
     if (_params.length == 1 || single === true) {
-      return _params[0];
+      param = _params[0];
     } else if (_params.length > 1) {
-      return _params;
+      param = _params;
     }
   } else {
-    let param2 = {};
+    param = {};
     for (const [key] of url.searchParams.entries()) {
-      if (typeof param2[key] === "undefined") {
+      if (typeof param[key] === "undefined") {
         let _params = url.searchParams.getAll(key);
-        param2[key] = _params.length < 2 || single === true ? _params[0] : _params;
+        param[key] = _params.length < 2 || single === true ? _params[0] : _params;
       }
     }
-    return param2;
   }
   return param;
 }
@@ -1431,9 +1425,6 @@ function numberWithCommas2(x) {
 function convertLBtoBR2(string) {
   return convertLBtoBR(string);
 }
-function decodeHtmlEntities2(string) {
-  return decodeHtmlEntities(string);
-}
 function getTimestamp2() {
   return getTimestamp();
 }
@@ -1558,7 +1549,7 @@ function acssel(_element, css) {
   return hec.acssel(_element, css);
 }
 function scssel(_element, rcss, acss) {
-  return hec.scssel(_element, rcss, acss);
+  hec.scssel(_element, rcss, acss);
 }
 function phfo(tree) {
   return hec.phfo(tree);

www/composer.json

@@ -15,7 +15,7 @@
         ]
     },
     "repositories": {
-        "git.egplusww.jp.Composer": {
+        "packages.omnicomproduction.jp.Composer": {
             "type": "composer",
             "url": "https://packages.omnicomproduction.jp/api/packages/Composer/composer"
         }
@@ -23,7 +23,7 @@
     "require": {
         "egrajp/smarty-extended": "^5.4",
         "php": ">=8.1",
-        "gullevek/dotenv": "^3.0",
+        "gullevek/dotenv": "^2.0",
         "psr/log": "^2.0 || ^3.0",
         "php-privacy/openpgp": "^2.1"
     }

www/lib/CoreLibs/Check/File.php

@@ -58,21 +58,15 @@ class File
 	 * else returns '' for any other finfo read problem
 	 *
 	 * @param  string $read_file File to read, relative or absolute path
-	 * @return string mime type
-	 * @throws \UnexpectedValueException if file cannot be read or is not a file
-	 * @throws \RangeException if we cannot get a mime type and throw exception is on
+	 * @return string
 	 */
 	public static function getMimeType(string $read_file): string
 	{
 		$finfo = new \finfo(FILEINFO_MIME_TYPE);
-		if (!is_file($read_file) || !is_readable($read_file)) {
+		if (!is_file($read_file)) {
 			throw new \UnexpectedValueException('[getMimeType] File not found: ' . $read_file);
 		}
-		$mime_type = $finfo->file($read_file);
-		if ($mime_type === false) {
-			throw new \RangeException('[getMimeType] Cannot get mime type for: ' . $read_file);
-		}
-		return $mime_type;
+		return $finfo->file($read_file) ?: '';
 	}
 }
 

www/lib/CoreLibs/Combined/ArrayHandler.php

@@ -811,6 +811,87 @@ class ArrayHandler
 		);
 		return $in_array;
 	}
+
+	/**
+	 * TODO: move to CoreLibs ArrayCombined
+	 * return one random entry from an array (value)
+	 * the return entry is null if the incoming array is empty
+	 * the array can also be an array of arrays
+	 *
+	 * @param  array<mixed> $array
+	 * @return string|int|float|bool|array<mixed>|null
+	 */
+	public static function getRandomEntryFromArray(array $array): string|int|float|bool|array|null
+	{
+		if (empty($array)) {
+			return null;
+		}
+		$random_index = array_rand($array);
+		return $array[$random_index];
+	}
+
+	/**
+	 * TODO: move to CoreLibs ArrayCombined
+	 * find and remove one value
+	 * on default removes only the first entry
+	 * on default does not strict compare
+	 *
+	 * @param  array<mixed>                       $array
+	 * @param  string|int|float|bool|array<mixed> $value
+	 * @param  bool                               $strict [false]
+	 * @return array<mixed>
+	 */
+	public static function removeArrayEntryByValue(
+		array $array,
+		string|int|float|bool|array $value,
+		bool $strict = false,
+	): array {
+		return array_filter($array, function ($element) use ($value, $strict) {
+			return $strict ?
+				$element !== $value :
+				$element != $value;
+		});
+	}
+
+	/**
+	 * TODO: move to CoreLibs ArrayCombined
+	 * add a string to each element in an array, default is at the end of the value,
+	 * can be switched with the prefix flag
+	 *
+	 * @param  array<string> $array
+	 * @param  string $string_to_add
+	 * @param  bool $prefix [false]
+	 * @return array<string>
+	 */
+	public static function addStringToEachValueInArray(array $array, string $string_to_add, bool $prefix = false): array
+	{
+		return array_map(function ($value) use ($string_to_add, $prefix) {
+			return $prefix ?
+				$string_to_add . $value :
+				$value . $string_to_add;
+		}, $array);
+	}
+
+	/**
+	 * sort by key any array, even if it is nested
+	 *
+	 * @param  array<mixed> $data
+	 * @return array<mixed>
+	 */
+	public static function createSortedArrayByKey(array $data): array
+	{
+		// Sort by keys
+		ksort($data);
+
+		// Recursively sort nested arrays
+		foreach ($data as $key => $value) {
+			if (is_array($value)) {
+				$data[$key] = self::createSortedArrayByKey($value);
+			}
+		}
+
+		return $data;
+	}
 }
 
 // __END__

www/lib/CoreLibs/Combined/DateTime.php

@@ -133,7 +133,7 @@ class DateTime
 		} else {
 			for ($i = 0, $iMax = count($timegroups); $i < $iMax; $i++) {
 				$output = floor((float)$timestamp / $timegroups[$i]);
-				$timestamp = $timestamp % $timegroups[$i];
+				$timestamp = (float)$timestamp % $timegroups[$i];
 				// output has days|hours|min|sec
 				if ($output || $time_string) {
 					$time_string .= $output . $labels[$i] . (($i + 1) != count($timegroups) ? ' ' : '');
@@ -453,7 +453,7 @@ class DateTime
 		}
 		if (isset($matches[11]) && is_numeric($matches[11])) {
 			// for milliseconds, we need to divide by 1000 and add them
-			$timestamp += ((float)$matches[11] / 1000);
+			$timestamp += (float)($matches[11] / 1000);
 		}
 		if ($negative) {
 			// cast to float so we can do a negative multiplication

www/lib/CoreLibs/Convert/Byte.php

@@ -43,70 +43,71 @@ class Byte
 	public static function humanReadableByteFormat(string|int|float $bytes, int $flags = 0): string
 	{
 		// if not numeric, return as is
-		if (!is_numeric($bytes)) {
+		if (is_numeric($bytes)) {
+			// flags bit wise check
+			// remove space between number and suffix
+			if ($flags & self::BYTE_FORMAT_NOSPACE) {
+				$space = false;
+			} else {
+				$space = true;
+			}
+			// use sprintf instead of round
+			if ($flags & self::BYTE_FORMAT_ADJUST) {
+				$adjust = true;
+			} else {
+				$adjust = false;
+			}
+			// use SI 1000 mod and not 1024 mod
+			if ($flags & self::BYTE_FORMAT_SI) {
+				$si = true;
+			} else {
+				$si = false;
+			}
+			if ($flags > 7) {
+				throw new \InvalidArgumentException("Invalid flags parameter: $flags", 1);
+			}
+
+			// si or normal
+			$unit = $si ? 1000 : 1024;
+			// always positive
+			$abs_bytes = $bytes == PHP_INT_MIN ? PHP_INT_MAX : abs((float)$bytes);
+			// smaller than unit is always B
+			if ($abs_bytes < $unit) {
+				return $bytes . 'B';
+			}
+			// labels in order of size [Y, Z]
+			$labels = ['', 'K', 'M', 'G', 'T', 'P', 'E'];
+			// exp position calculation
+			$exp = (int)floor(log($abs_bytes, $unit));
+			// avoid printing out anything larger than max labels
+			if ($exp >= count($labels)) {
+				$exp = count($labels) - 1;
+			}
+			// deviation calculation
+			$dev = pow($unit, $exp) * ($unit - 0.05);
+			// shift the exp +1 for on the border units
+			if (
+				$exp < 6 &&
+				$abs_bytes > ($dev - (((int)$dev & 0xfff) == 0xd00 ? 52 : 0))
+			) {
+				$exp++;
+			}
+			// label name, including leading space if flagged
+			$pre = ($space ? ' ' : '') . ($labels[$exp] ?? '>E') . ($si ? 'i' : '') . 'B';
+			$bytes_calc = $abs_bytes / pow($unit, $exp);
+			// if original is negative, reverse
+			if ($bytes < 0) {
+				$bytes_calc *= -1;
+			}
+			if ($adjust) {
+				return sprintf("%.2f%s", $bytes_calc, $pre);
+			} else {
+				return round($bytes_calc, 2) . $pre;
+			}
+		} else {
 			// if anything other return as string
 			return (string)$bytes;
 		}
-		// flags bit wise check
-		// remove space between number and suffix
-		if ($flags & self::BYTE_FORMAT_NOSPACE) {
-			$space = false;
-		} else {
-			$space = true;
-		}
-		// use sprintf instead of round
-		if ($flags & self::BYTE_FORMAT_ADJUST) {
-			$adjust = true;
-		} else {
-			$adjust = false;
-		}
-		// use SI 1000 mod and not 1024 mod
-		if ($flags & self::BYTE_FORMAT_SI) {
-			$si = true;
-		} else {
-			$si = false;
-		}
-		if ($flags > 7) {
-			throw new \InvalidArgumentException("Invalid flags parameter: $flags", 1);
-		}
-
-		// si or normal
-		$unit = $si ? 1000 : 1024;
-		// always positive
-		$abs_bytes = $bytes == PHP_INT_MIN ? PHP_INT_MAX : abs((float)$bytes);
-		// smaller than unit is always B
-		if ($abs_bytes < $unit) {
-			return $bytes . 'B';
-		}
-		// labels in order of size [Y, Z]
-		$labels = ['', 'K', 'M', 'G', 'T', 'P', 'E'];
-		// exp position calculation
-		$exp = (int)floor(log($abs_bytes, $unit));
-		// avoid printing out anything larger than max labels
-		if ($exp >= count($labels)) {
-			$exp = count($labels) - 1;
-		}
-		// deviation calculation
-		$dev = pow($unit, $exp) * ($unit - 0.05);
-		// shift the exp +1 for on the border units
-		if (
-			$exp < 6 &&
-			$abs_bytes > ($dev - (((int)$dev & 0xfff) == 0xd00 ? 52 : 0))
-		) {
-			$exp++;
-		}
-		// label name, including leading space if flagged
-		$pre = ($space ? ' ' : '') . ($labels[$exp] ?? '>E') . ($si ? 'i' : '') . 'B';
-		$bytes_calc = $abs_bytes / pow($unit, $exp);
-		// if original is negative, reverse
-		if ($bytes < 0) {
-			$bytes_calc *= -1;
-		}
-		if ($adjust) {
-			return sprintf("%.2f%s", $bytes_calc, $pre);
-		} else {
-			return round($bytes_calc, 2) . $pre;
-		}
 	}
 
 	/**
@@ -153,7 +154,7 @@ class Byte
 		if (!empty($matches[1])) {
 			$number_negative = true;
 		}
-		if (isset($matches[2])) {
+		if (isset($matches[2]) && isset($matches[3])) {
 			// remove all non valid characters from the number
 			$number = preg_replace('/[^0-9\.]/', '', $matches[2]);
 			// final clean up and convert to float

www/lib/CoreLibs/Convert/Color/Color.php

@@ -957,9 +957,9 @@ class Color
 	 * Undocumented function
 	 *
 	 * @param  HWB $hwb
-	 * @return LCH
+	 * @return Lch
 	 */
-	public static function hwbToLch(HWB $hwb): LCH
+	public static function hwbToLch(HWB $hwb): Lch
 	{
 		return self::rgbToLch(
 			self::hwbToRgb($hwb)
@@ -1078,10 +1078,10 @@ class Color
 	/**
 	 * OkLab to Lch (CIE)
 	 *
-	 * @param  Lab $lab
+	 * @param  LAB $lab
 	 * @return LCH
 	 */
-	public static function okLabToLch(Lab $lab): LCH
+	public static function okLabToLch(LAB $lab): LCH
 	{
 		return self::labToLch(
 			self::okLabToLab($lab)
@@ -1092,9 +1092,9 @@ class Color
 	 * Lch (CIE) to OkLab
 	 *
 	 * @param  LCH $lch
-	 * @return Lab
+	 * @return LAB
 	 */
-	public static function lchToOkLab(LCH $lch): Lab
+	public static function lchToOkLab(LCH $lch): LAB
 	{
 		return self::labToOkLab(
 			self::lchToLab($lch)

www/lib/CoreLibs/Convert/Json.php

@@ -74,15 +74,11 @@ class Json
 	 * Weill set the internval last error state and info can be read with jsonGetLastError
 	 *
 	 * @param  string $json
-	 * @param  int $flags only JSON_INVALID_UTF8_IGNORE is currently allowed
+	 * @param  int    $flags only JSON_INVALID_UTF8_IGNORE is currently allowed
 	 * @return bool
-	 * @throws \InvalidArgumentException if flags is invalid
 	 */
 	public static function jsonValidate(string $json, int $flags = 0): bool
 	{
-		if ($flags != 0 && $flags != JSON_INVALID_UTF8_IGNORE) {
-			throw new \InvalidArgumentException("For flag only 0 or JSON_INVALID_UTF8_IGNORE is allwed: " . $flags);
-		}
 		$json_valid = json_validate($json, flags:$flags);
 		self::$json_last_error = json_last_error();
 		return $json_valid;

www/lib/CoreLibs/DB/IO.php

@@ -2232,9 +2232,9 @@ class IO
 		$milliseconds = $matches[13] ?? '';
 
 		// clean up, hide entries that have 00 in the time group
-		$hour = !empty($hour) ? preg_replace('/^0/', '', $hour) : '';
-		$minutes = !empty($minutes) ? preg_replace('/^0/', '', $minutes) : '';
-		$seconds = !empty($seconds) ? preg_replace('/^0/', '', $seconds) : '';
+		$hour = $hour != '00' ? preg_replace('/^0/', '', $hour) : '';
+		$minutes = $minutes != '00' ? preg_replace('/^0/', '', $minutes) : '';
+		$seconds = $seconds != '00' ? preg_replace('/^0/', '', $seconds) : '';
 
 		// strip any leading or trailing spaces
 		$time_string = trim(
@@ -2562,27 +2562,21 @@ class IO
 				// set field names
 				$this->cursor_ext[$query_hash]['field_names'] = [];
 				for ($i = 0; $i < $this->cursor_ext[$query_hash]['num_fields']; $i++) {
-					if (
-						($field_name = $this->db_functions->__dbFieldName(
+					$this->cursor_ext[$query_hash]['field_names'][] =
+						$this->db_functions->__dbFieldName(
 							$this->cursor_ext[$query_hash]['cursor'],
 							$i
-						)) !== false
-					) {
-						$this->cursor_ext[$query_hash]['field_names'][] = $field_name;
-					}
+						);
 				}
 				$this->field_names = $this->cursor_ext[$query_hash]['field_names'];
 				// field types
 				$this->cursor_ext[$query_hash]['field_types'] = [];
 				for ($i = 0; $i < $this->cursor_ext[$query_hash]['num_fields']; $i++) {
-					if (
-						($field_type = $this->db_functions->__dbFieldType(
+					$this->cursor_ext[$query_hash]['field_types'][] =
+						$this->db_functions->__dbFieldType(
 							$this->cursor_ext[$query_hash]['cursor'],
 							$i
-						)) !== false
-					) {
-						$this->cursor_ext[$query_hash]['field_types'][] = $field_type;
-					}
+						);
 				}
 				$this->field_types = $this->cursor_ext[$query_hash]['field_types'];
 				// combined name => type

www/lib/CoreLibs/Language/L10n.php

@@ -146,7 +146,7 @@ class L10n
 	 * @param string $locale language name, if not set, try previous set
 	 * @param string $domain set name for mo file, if not set, try previous set
 	 * @param string $path path, if not set try to get from paths array, else self
-	 * @param string $override_encoding if locale does not have encoding set, use this one
+	 * @param string $override_encoding if locale does not env encoding set, use this one
 	 * @return GetTextReader the main gettext reader object
 	 */
 	public function getTranslator(
@@ -301,7 +301,7 @@ class L10n
 	 * Get the local as array same to the GetLocale::setLocale return
 	 * This does not set from outside, but only what is set in the l10n class
 	 *
-	 * @return array{locale:string,lang:string,lang_short:string,domain:string,encoding:string,path:string}
+	 * @return array{locale: string, lang: string, lang_short: string, domain: string, encoding: string, path: string}
 	 */
 	public function getLocaleAsArray(): array
 	{
@@ -321,7 +321,7 @@ class L10n
 	 * parse the locale string for further processing
 	 *
 	 * @param  string $locale Locale to parse
-	 * @return array{lang:string|null,country:string|null,charset:string|null,modifier:string|null} parsed locale
+	 * @return array<string,string|null> array with lang, country, charset, modifier
 	 */
 	public static function parseLocale(string $locale = ''): array
 	{

www/lib/CoreLibs/Logging/Logger/Level.php

@@ -86,7 +86,7 @@ enum Level: int
 
 	/**
 	 * @param value-of<self::NAMES>|LogLevel::*|'Debug'|'Info'|'Notice'|'Warning'|'Error'|'Critical'|'Alert'|'Emergency' $name
-	 * @return self
+	 * @return static
 	 */
 	public static function fromName(string $name): self
 	{
@@ -104,7 +104,7 @@ enum Level: int
 
 	/**
 	 * @param value-of<self::VALUES> $value
-	 * @return self
+	 * @return static
 	 */
 	public static function fromValue(int $value): self
 	{

www/lib/CoreLibs/Output/Form/Elements.php

@@ -178,11 +178,11 @@ class Elements
 			"/(href=\")?(\>)?\b($protRegex)([\w\.\-?&=+%#~,;\/]+)\b([\.\-?&=+%#~,;\/]*)(\|([^\||^#]+)(#([^\|]+))?\|)?/",
 			function ($matches) {
 				return self::createUrl(
-					$matches[1],
-					$matches[2],
-					$matches[3],
-					$matches[4],
-					$matches[5],
+					$matches[1] ?? '',
+					$matches[2] ?? '',
+					$matches[3] ?? '',
+					$matches[4] ?? '',
+					$matches[5] ?? '',
 					$matches[7] ?? '',
 					$matches[9] ?? ''
 				);
@@ -232,15 +232,8 @@ class Elements
 	 * @param  string $class style sheet
 	 * @return string        correct string for url href process
 	 */
-	private static function createUrl(
-		string $href,
-		string $atag,
-		string $_1,
-		string $_2,
-		string $_3,
-		string $name,
-		string $class
-	): string {
+	private static function createUrl($href, $atag, $_1, $_2, $_3, $name, $class): string
+	{
 		// $this->debug('URL', "1: $_1 - 2: $_2 - $_3 - atag: $atag - name: $name - class: $class");
 		// if $_1 ends with //, then we strip $_1 complete & target is also blanked (its an internal link)
 		if (preg_match("/\/\/$/", $_1) && preg_match("/^\//", $_2)) {
@@ -257,8 +250,11 @@ class Elements
 				. "##GT##" . ($name ? $name : $_2 . $_3) . "##LT##/a##GT##";
 		} elseif ($href && !$atag) {
 			return "href=##QUOT##$_1$_2$_3##QUOT##";
+		} elseif ($atag) {
+			return $atag . $_2 . $_3;
+		} else {
+			return $href;
 		}
-		return $atag . $_2 . $_3;
 	}
 
 	/**
@@ -273,15 +269,8 @@ class Elements
 	 * @param  string $class  style sheet
 	 * @return string         created html email a href string
 	 */
-	private static function createEmail(
-		string $mailto,
-		string $atag,
-		string $_1,
-		string $_2,
-		string $_3,
-		string $title,
-		string $class
-	): string {
+	private static function createEmail($mailto, $atag, $_1, $_2, $_3, $title, $class)
+	{
 		$email = $_1 . "@" . $_2 . "." . $_3;
 		if (!$mailto && !$atag) {
 			return "##LT##a href=##QUOT##mailto:" . $email . "##QUOT##"
@@ -289,8 +278,12 @@ class Elements
 				. "##GT##" . ($title ? $title : $email) . "##LT##/a##GT##";
 		} elseif ($mailto && !$atag) {
 			return "mailto:" . $email;
+		} elseif ($atag) {
+			return $atag . $email;
+		} else {
+			// else just return email as is
+			return $email;
 		}
-		return $atag . $email;
 	}
 }
 

www/lib/CoreLibs/UrlRequests/Curl.php

@@ -954,10 +954,11 @@ class Curl implements Interface\RequestsInterface
 				)
 			) {
 				unset($this->config['headers'][$header_key]);
-				unset($this->headers_named[strtolower($header_key)]);
+				unset($this->headers_named[$header_key]);
 			} elseif (
-				// right side is array, and value is anything string or array
-				// if right side is string, and we give value array, we do nothing
+				// string value, array keys = in
+				// or both array and not a full match in the one before
+				(is_string($value) || is_array($value)) &&
 				is_array($this->config['headers'][$header_key])
 			) {
 				// part remove of key, value must be array
@@ -965,14 +966,10 @@ class Curl implements Interface\RequestsInterface
 					$value = [$value];
 				}
 				// array values so we rewrite the key pos
-				/** @var array<int|string,string> $headers */
-				$headers = $this->config['headers'][$header_key];
-				$this->config['headers'][$header_key] = array_values(
-					array_diff(
-						$headers,
-						$value
-					)
-				);
+				$this->config['headers'][$header_key] = array_values(array_diff(
+					$this->config['headers'][$header_key],
+					$value
+				));
 			}
 		}
 	}