Update byteStringFormat with si units and bitwise mask

The old method name byteStringFormat is currently deprecated and it is recommended to move to the new humanReadableByteFormat method. Difference is that the new version uses a bitfield settings mask BYTE_FORMAT_NOSPACE, BYTE_FORMAT_ADJUST, BYTE_FORMAT_SI
Fixups for phan 2.4.4 run checks
2019-12-06 15:29:06 +09:00 · 2019-12-05 16:01:44 +09:00 · 2019-12-04 12:12:43 +09:00 · 2019-11-28 15:44:39 +09:00 · 2019-11-15 17:53:21 +09:00 · 2019-11-15 17:07:35 +09:00
10 changed files with 536 additions and 215 deletions
--- a/www/admin/class_test.php
+++ b/www/admin/class_test.php
@@ -24,12 +24,10 @@ if (!defined('SET_SESSION_NAME')) {
 }
 // define log file id
 $LOG_FILE_ID = 'classTest';
-// set language for l10n
-$lang = 'en_utf8';

 // init login & backend class
-$login = new CoreLibs\ACL\Login(DB_CONFIG, $lang);
-$basic = new CoreLibs\Admin\Backend(DB_CONFIG, $lang);
+$login = new CoreLibs\ACL\Login(DB_CONFIG);
+$basic = new CoreLibs\Admin\Backend(DB_CONFIG);
 $basic->dbInfo(true);
 ob_end_flush();

@@ -256,6 +254,45 @@ echo "SOURCE ARRAY: ".$basic->printAr($test_array)."<br>";
 echo "FOUND ELEMENTS [base]: ".$basic->printAr($basic->arraySearchRecursive('email', $test_array, 'type'))."<br>";
 echo "FOUND ELEMENTS [input]: ".$basic->printAr($basic->arraySearchRecursive('email', $test_array['input'], 'type'))."<br>";

+// *** BYTES TEST ***
+$bytes = array(
+	-123123123,
+	999999, // KB-1
+	999999999, // MB-1
+	254779258, // MB-n
+	999999999999999, // TB-1
+	588795544887632, // TB-n
+	999999999999999999, // PB-1
+	9223372036854775807, // MAX INT
+	999999999999999999999, // EB-1
+);
+print "<b>BYTE FORMAT TESTS</b><br>";
+foreach ($bytes as $byte) {
+	print '<div style="display: flex; border-bottom: 1px dashed gray;">';
+	//
+	print '<div style="width: 35%; text-align: right; padding-right: 2px;">';
+	print "(".number_format($byte)."/".$byte.") bytes :";
+	print '</div><div style="width: 40%;">';
+	print $basic->humanReadableByteFormat($byte);
+	print "</div>";
+	//
+	print "</div>";
+	//
+	print '<div style="display: flex; border-bottom: 1px dotted red;">';
+	//
+	print '<div style="width: 35%; text-align: right; padding-right: 2px;">';
+	print "bytes [si]:";
+	print '</div><div style="width: 40%;">';
+	// print $basic->byteStringFormat($byte, true, false, true);
+	print $basic->humanReadableByteFormat($byte, $basic::BYTE_FORMAT_SI);
+	print "</div>";
+	//
+	print "</div>";
+}
+
+
+// *** IMAGE TESTS ***
+echo "<hr>";
 // image thumbnail
 $images = array(
 	// height bigger
@@ -274,7 +311,6 @@ $images = array(
 	// Photoshop
 	'photoshop_test.psd',
 );
-echo "<hr>";
 $thumb_width = 250;
 $thumb_height = 300;
 // return mime type ala mimetype
--- a/www/admin/namespace_test.php
+++ b/www/admin/namespace_test.php
@@ -14,16 +14,15 @@ $SET_SESSION_NAME = EDIT_SESSION_NAME;

 echo "DIR: ".DIR."<br>ROOT: ".ROOT."<br>BASE: ".BASE."<br>";

-$lang = 'ja_utf8';
-$base = new CoreLibs\Admin\Backend(DB_CONFIG, $lang);
+$base = new CoreLibs\Admin\Backend(DB_CONFIG);
 ob_end_flush();
 if ($base->getConnectionStatus()) {
 	die("Cannot connect to database");
 }

 print "Start time: ".$base->runningTime()."<br>";
-print "ByteStringFormat: ".$base->ByteStringFormat(1234567.12)."<br>";
-print "byteStringFormat: ".$base->byteStringFormat(1234567.12)."<br>";
+print "HumanReadableByteFormat: ".$base->HumanReadableByteFormat(1234567.12)."<br>";
+print "humanReadableByteFormat: ".$base->humanReadableByteFormat(1234567.12)."<br>";
 // print "get_page_name [DEPRECATED]: ".$base->get_page_name()."<br>";
 print "getPageName: ".$base->getPageName()."<br>";

--- a/www/includes/admin_header.php
+++ b/www/includes/admin_header.php
@@ -13,7 +13,6 @@ if ($DEBUG_ALL && $ENABLE_ERROR_HANDLING) {
 	include BASE.LIBS."Error.Handling.php";
 }
 // predefine vars
-$LANG = '';
 $messages = array();
 // import all POST vars
 // extract($_POST, EXTR_SKIP);
@@ -38,12 +37,6 @@ if (!isset($ZIP_STREAM)) {
 if (!isset($ENCODING) || !$ENCODING) {
 	$ENCODING = DEFAULT_ENCODING;
 }
-// set the default lang, if not given
-if (session_id() && isset($_SESSION['DEFAULT_LANG']) && $_SESSION['DEFAULT_LANG']) {
-	$LANG = $_SESSION['DEFAULT_LANG'];
-} else {
-	$LANG = defined('SITE_LANG') ? SITE_LANG : DEFAULT_LANG;
-}
 // end the stop of the output flow, but only if we didn't request a csv file download
 if (isset($_POST['action']) && $_POST['action'] != 'download_csv' && !$AJAX_PAGE) {
 	header("Content-type: text/html; charset=".$ENCODING);
@@ -55,15 +48,11 @@ if ($AJAX_PAGE && !$ZIP_STREAM) {

 //------------------------------ class init start
 // login & page access check
-$login = new CoreLibs\ACL\Login(DB_CONFIG, $LANG);
-// post login lang check
-if (isset($_SESSION['DEFAULT_LANG'])) {
-	$LANG = $_SESSION['DEFAULT_LANG'];
-}
+$login = new CoreLibs\ACL\Login(DB_CONFIG);
 // create smarty object
-$smarty = new CoreLibs\Template\SmartyExtend($LANG);
+$smarty = new CoreLibs\Template\SmartyExtend();
 // create new DB class
-$cms = new CoreLibs\Admin\Backend(DB_CONFIG, $LANG);
+$cms = new CoreLibs\Admin\Backend(DB_CONFIG);
 // the menu show flag (what menu to show)
 $cms->menu_show_flag = 'main';
 // db nfo
--- a/www/includes/edit_base.php
+++ b/www/includes/edit_base.php
@@ -36,23 +36,19 @@ if (!DEBUG)	{
 	$ECHO_ALL = 0;
 }

-// set default lang if not set otherwise
-if (!isset($lang)) {
-	$lang = DEFAULT_LANG;
-}
 // should be utf8
 header("Content-type: text/html; charset=".DEFAULT_ENCODING);
 ob_end_flush();
-$login = new CoreLibs\ACL\Login(DB_CONFIG, $lang);
+$login = new CoreLibs\ACL\Login(DB_CONFIG);

 // create form class
-$form = new CoreLibs\Output\Form\Generate(DB_CONFIG, $lang);
+$form = new CoreLibs\Output\Form\Generate(DB_CONFIG);
 if ($form->mobile_phone) {
 	echo "I am sorry, but this page cannot be viewed by a mobile phone";
 	exit;
 }
 // smarty template engine (extended Translation version)
-$smarty = new CoreLibs\Template\SmartyExtend($lang);
+$smarty = new CoreLibs\Template\SmartyExtend();

 // $form->debug('POST', $form->printAr($_POST));

@@ -453,7 +449,7 @@ if (is_dir(BASE.TEMPLATES_C)) {
 if (is_dir(BASE.CACHE)) {
 	$smarty->setCacheDir(BASE.CACHE);
 }
-$smarty->display($EDIT_TEMPLATE, 'editAdmin_'.$lang, 'editAdmin_'.$lang);
+$smarty->display($EDIT_TEMPLATE, 'editAdmin_'.$smarty->lang, 'editAdmin_'.$smarty->lang);

 // debug output
 echo $login->printErrorMsg();
--- a/www/lib/CoreLibs/ACL/Login.php
+++ b/www/lib/CoreLibs/ACL/Login.php
@@ -115,10 +115,9 @@ class Login extends \CoreLibs\DB\IO
 	/**
 	 * constructor, does ALL, opens db, works through connection checks, closes itself
 	 * @param array  $db_config        db config array
-	 * @param string $lang             language string (default en_utf8)
 	 * @param int    $set_control_flag class variable check flags
 	 */
-	public function __construct(array $db_config, string $lang = 'en_utf8', int $set_control_flag = 0)
+	public function __construct(array $db_config, int $set_control_flag = 0)
 	{
 		// log login data for this class only
 		$this->log_per_class = 1;
@@ -151,7 +150,13 @@ class Login extends \CoreLibs\DB\IO
 		// set global is ajax page for if we show the data directly, or need to pass it back
 		// to the continue AJAX class for output back to the user
 		$this->login_is_ajax_page = isset($GLOBALS['AJAX_PAGE']) && $GLOBALS['AJAX_PAGE'] ? true : false;
-
+		// set the default lang
+		$lang = 'en_utf8';
+		if (session_id() && isset($_SESSION['DEFAULT_LANG']) && $_SESSION['DEFAULT_LANG']) {
+			$lang = $_SESSION['DEFAULT_LANG'];
+		} else {
+			$lang = defined('SITE_LANG') ? SITE_LANG : DEFAULT_LANG;
+		}
 		$this->l = new \CoreLibs\Language\L10n($lang);

 		// if we have a search path we need to set it, to use the correct DB to login
@@ -173,44 +178,17 @@ class Login extends \CoreLibs\DB\IO
 		$this->euid = array_key_exists('EUID', $_SESSION) ? $_SESSION['EUID'] : 0; // if there is none, there is none, saves me POST/GET check
 		// get login vars, are so, can't be changed
 		// prepare
-		if (!isset($_POST['login_login'])) {
-			$_POST['login_login'] = '';
-		}
-		if (!isset($_POST['login_username'])) {
-			$_POST['login_username'] = '';
-		}
-		if (!isset($_POST['login_password'])) {
-			$_POST['login_password'] = '';
-		}
-		if (!isset($_POST['login_logout'])) {
-			$_POST['login_logout'] = '';
-		}
-		if (!isset($_POST['change_password'])) {
-			$_POST['change_password'] = '';
-		}
-		if (!isset($_POST['pw_username'])) {
-			$_POST['pw_username'] = '';
-		}
-		if (!isset($_POST['pw_old_password'])) {
-			$_POST['pw_old_password'] = '';
-		}
-		if (!isset($_POST['pw_new_password'])) {
-			$_POST['pw_new_password'] = '';
-		}
-		if (!isset($_POST['pw_new_password_confirm'])) {
-			$_POST['pw_new_password_confirm'] = '';
-		}
 		// pass on vars to Object vars
-		$this->login = $_POST['login_login'];
-		$this->username = $_POST['login_username'];
-		$this->password = $_POST['login_password'];
-		$this->logout = $_POST['login_logout'];
+		$this->login = isset($_POST['login_login']) ? $_POST['login_login'] : '';
+		$this->username = isset($_POST['login_username']) ? $_POST['login_username'] : '';
+		$this->password = isset($_POST['login_password']) ? $_POST['login_password'] : '';
+		$this->logout = isset($_POST['login_logout']) ? $_POST['login_logout'] : '';
 		// password change vars
-		$this->change_password = $_POST['change_password'];
-		$this->pw_username = $_POST['pw_username'];
-		$this->pw_old_password = $_POST['pw_old_password'];
-		$this->pw_new_password = $_POST['pw_new_password'];
-		$this->pw_new_password_confirm = $_POST['pw_new_password_confirm'];
+		$this->change_password = isset($_POST['change_password']) ? $_POST['change_password'] : '';
+		$this->pw_username = isset($_POST['pw_username']) ? $_POST['pw_username'] : '';
+		$this->pw_old_password = isset($_POST['pw_old_password']) ? $_POST['pw_old_password'] : '';
+		$this->pw_new_password = isset($_POST['pw_new_password']) ? $_POST['pw_new_password'] : '';
+		$this->pw_new_password_confirm = isset($_POST['pw_new_password_confirm']) ? $_POST['pw_new_password_confirm'] : '';
 		// logout target (from config)
 		$this->logout_target = LOGOUT_TARGET;
 		// disallow user list for password change
--- a/www/lib/CoreLibs/Admin/Backend.php
+++ b/www/lib/CoreLibs/Admin/Backend.php
@@ -57,26 +57,25 @@ class Backend extends \CoreLibs\DB\IO
 	public $lang;
 	public $lang_short;
 	public $encoding;
+	// language
+	public $l;
 	// smarty publics [end processing in smarty class]
 	public $DATA;
 	public $HEADER;
 	public $DEBUG_DATA;
 	public $CONTENT_DATA;
-	// language
-	public $l;

 	// CONSTRUCTOR / DECONSTRUCTOR |====================================>
 	/**
 	 * main class constructor
 	 * @param array       $db_config        db config array
-	 * @param string      $lang             language string
 	 * @param int|integer $set_control_flag class variable check flag
 	 */
-	public function __construct(array $db_config, string $lang, int $set_control_flag = 0)
+	public function __construct(array $db_config, int $set_control_flag = 0)
 	{
 		$this->setLangEncoding();
 		// get the language sub class & init it
-		$this->l = new \CoreLibs\Language\L10n($lang);
+		$this->l = new \CoreLibs\Language\L10n($this->lang);

 		// init the database class
 		parent::__construct($db_config, $set_control_flag);
@@ -104,11 +103,9 @@ class Backend extends \CoreLibs\DB\IO

 	// INTERNAL METHODS |===============================================>

-
-	// PUBLIC METHODS |=================================================>
-
 	/**
 	 * set the language encoding and language settings
+	 * use $OVERRIDE_LANG to override all language settings
 	 * the default charset from _SESSION login or from
 	 * config DEFAULT ENCODING
 	 * the lang full name for mo loading from _SESSION login
@@ -116,7 +113,7 @@ class Backend extends \CoreLibs\DB\IO
 	 * creates short lang (only first two chars) from the lang
 	 * @return void
 	 */
-	public function setLangEncoding(): void
+	private function setLangEncoding(): void
 	{
 		// just emergency fallback for language
 		// set encoding
@@ -125,10 +122,14 @@ class Backend extends \CoreLibs\DB\IO
 		} else {
 			$this->encoding = DEFAULT_ENCODING;
 		}
-		// just emergency fallback for language
-		if (isset($_SESSION['DEFAULT_LANG'])) {
+		// gobal override
+		if (isset($GLOBALS['OVERRIDE_LANG'])) {
+			$this->lang = $GLOBALS['OVERRIDE_LANG'];
+		} elseif (isset($_SESSION['DEFAULT_LANG'])) {
+			// session (login)
 			$this->lang = $_SESSION['DEFAULT_LANG'];
 		} else {
+			// mostly default SITE LANG or DEFAULT LANG
 			$this->lang = defined('SITE_LANG') ? SITE_LANG : DEFAULT_LANG;
 		}
 		// create the char lang encoding
@@ -137,6 +138,8 @@ class Backend extends \CoreLibs\DB\IO
 		$this->lang_dir = BASE.INCLUDES.LANG.CONTENT_PATH;
 	}

+	// PUBLIC METHODS |=================================================>
+
 	/**
 	 * set internal ACL from login ACL
 	 * @param array $acl login acl array
@@ -184,7 +187,7 @@ class Backend extends \CoreLibs\DB\IO
 		$q .= "VALUES ";
 		$q .= "(".$this->dbEscapeString(isset($_SESSION['EUID']) && is_numeric($_SESSION['EUID']) ? $_SESSION['EUID'] : 'NULL').", ";
 		$q .= "NOW(), ";
-		$q .= "'".$this->dbEscapeString((string)$event)."', '".$data."', '".$data_binary."', '".$this->dbEscapeString($this->page_name)."', ";
+		$q .= "'".$this->dbEscapeString((string)$event)."', '".$data."', '".$data_binary."', '".$this->dbEscapeString((string)$this->page_name)."', ";
 		$q .= "'".@$_SERVER["REMOTE_ADDR"]."', '".$this->dbEscapeString(@$_SERVER['HTTP_USER_AGENT'])."', ";
 		$q .= "'".$this->dbEscapeString(isset($_SERVER['HTTP_REFERER']) ? $_SERVER['HTTP_REFERER'] : '')."', ";
 		$q .= "'".$this->dbEscapeString(isset($_SERVER['SCRIPT_FILENAME']) ? $_SERVER['SCRIPT_FILENAME'] : '')."', ";
@@ -206,42 +209,6 @@ class Backend extends \CoreLibs\DB\IO
 		$this->dbExec($q, 'NULL');
 	}

-	/**
-	 * helper function for PHP file upload error messgaes to messge string
-	 * @param  int    $error_code integer _FILE upload error code
-	 * @return string                     message string, translated
-	 */
-	public function fileUploadErrorMessage(int $error_code): string
-	{
-		switch ($error_code) {
-			case UPLOAD_ERR_INI_SIZE:
-				$message = 'The uploaded file exceeds the upload_max_filesize directive in php.ini';
-				break;
-			case UPLOAD_ERR_FORM_SIZE:
-				$message = 'The uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the HTML form';
-				break;
-			case UPLOAD_ERR_PARTIAL:
-				$message = 'The uploaded file was only partially uploaded';
-				break;
-			case UPLOAD_ERR_NO_FILE:
-				$message = 'No file was uploaded';
-				break;
-			case UPLOAD_ERR_NO_TMP_DIR:
-				$message = 'Missing a temporary folder';
-				break;
-			case UPLOAD_ERR_CANT_WRITE:
-				$message = 'Failed to write file to disk';
-				break;
-			case UPLOAD_ERR_EXTENSION:
-				$message = 'File upload stopped by extension';
-				break;
-			default:
-				$message = 'Unknown upload error';
-				break;
-		}
-		return $this->l->__($message);
-	}
-
 	/**
 	 * menu creater (from login menu session pages)
 	 * @param  int $flag visible flag trigger
@@ -266,13 +233,14 @@ class Backend extends \CoreLibs\DB\IO
 		// if flag is 0, then we show all, else, we show only the matching flagges array points
 		// array is already sorted after correct order
 		reset($pages);
-		for ($i = 0, $iMax = count($pages); $i < $iMax; $i ++) {
+		foreach ($pages as $i => $data) {
+		// for ($i = 0, $iMax = count($pages); $i < $iMax; $i ++) {
 			$show = 0;
 			// is it visible in the menu & is it online
-			if ($pages[$i]['menu'] && $pages[$i]['online']) {
+			if ($data['menu'] && $data['online']) {
 				// check if it falls into our flag if we have a flag
 				if ($flag) {
-					foreach ($pages[$i]['visible'] as $name => $key) {
+					foreach ($data['visible'] as $name => $key) {
 						if ($key == $flag) {
 							$show = 1;
 						}
@@ -284,40 +252,59 @@ class Backend extends \CoreLibs\DB\IO

 				if ($show) {
 					// if it is popup, write popup arrayound
-					if (isset($pages[$i]['popup']) && $pages[$i]['popup']) {
+					if (isset($data['popup']) && $data['popup']) {
 						$type = 'popup';
 					} else {
 						$type = 'normal';
-						$pages[$i]['popup'] = 0;
+						$data['popup'] = 0;
 					}
 					$query_string = '';
-					if (isset($pages[$i]['query']) && count($pages[$i]['query'])) {
-						for ($j = 0, $jMax = count($pages[$i]['query']); $j < $jMax; $j ++) {
-							if (strlen($query_string)) {
-								$query_string .= '&';
-							}
-							$query_string .= $pages[$i]['query'][$j]['name'].'=';
-							if (!$pages[$i]['query'][$j]['dynamic']) {
-								$query_string .= urlencode($pages[$i]['query'][$j]['value']);
-							} else {
-								$query_string .= $_GET[$pages[$i]['query'][$j]['value']] ? urlencode($_GET[$pages[$i]['query'][$j]['value']]) : urlencode($_POST[$pages[$i]['query'][$j]['value']]);
+
+					if (isset($data['query']) &&
+						is_array($data['query']) &&
+						count($data['query'])
+					) {
+						// for ($j = 0, $jMax = count($pages[$i]['query']); $j < $jMax; $j ++) {
+						foreach ($data['query'] as $j => $query) {
+							if (!empty($query['name']) &&
+								!empty($query['value'])
+							) {
+								if (strlen($query_string)) {
+									$query_string .= '&';
+								}
+								$query_string .= $query['name'].'=';
+								if (isset($query['dynamic']) &&
+									$query['dynamic']
+								) {
+									if (isset($_GET[$query['value']])) {
+										$query_string .= urlencode($_GET[$query['value']]);
+									} elseif (isset($_POST[$query['value']])) {
+										$query_string .= urlencode($_POST[$query['value']]);
+									}
+								} else {
+									$query_string .= urlencode($query['value']);
+								}
 							}
 						}
 					}
-					$url = $pages[$i]['filename'];
+					$url = isset($data['filename']) ? $data['filename'] : '';
 					if (strlen($query_string)) {
 						$url .= '?'.$query_string;
 					}
-					$name = $pages[$i]['page_name'];
+					$name = isset($data['page_name']) ? $data['page_name'] : '';
 					// if page name matchs -> set selected flag
 					$selected = 0;
-					if ($this->getPageName() == $pages[$i]['filename']) {
+					if (isset($data['filename']) &&
+						$this->getPageName() == $data['filename']
+					) {
 						$selected = 1;
 						$this->page_name = $name;
 					}
 					// last check, is this menu point okay to show
 					$enabled = 0;
-					if ($this->adbShowMenuPoint($pages[$i]['filename'])) {
+					if (isset($data['filename']) &&
+						$this->adbShowMenuPoint($data['filename'])
+					) {
 						$enabled = 1;
 					}
 					// write in to view menu array
@@ -337,12 +324,15 @@ class Backend extends \CoreLibs\DB\IO

 	/**
 	 * checks if this filename is in the current situation (user id, etc) available
-	 * @param  string $filename filename
-	 * @return bool             true for visible/accessable menu point, false for not
+	 * @param  string|null $filename filename
+	 * @return bool                  true for visible/accessable menu point, false for not
 	 */
-	public function adbShowMenuPoint(string $filename): bool
+	public function adbShowMenuPoint(?string $filename): bool
 	{
 		$enabled = false;
+		if ($filename === null) {
+			return $enabled;
+		}
 		switch ($filename) {
 			default:
 				$enabled = true;
@@ -374,7 +364,7 @@ class Backend extends \CoreLibs\DB\IO
 	public function adbByteStringFormat($number): string
 	{
 		trigger_error('Method '.__METHOD__.' is deprecated', E_USER_DEPRECATED);
-		return $this->byteStringFormat($number);
+		return $this->humanReadableByteFormat($number);
 	}

 	/**
--- a/www/lib/CoreLibs/Basic.php
+++ b/www/lib/CoreLibs/Basic.php
@@ -100,6 +100,10 @@ class Basic
 	// define check vars for the flags we can have
 	const CLASS_STRICT_MODE = 1;
 	const CLASS_OFF_COMPATIBLE_MODE = 2;
+	// define byteFormat
+	const BYTE_FORMAT_NOSPACE = 1;
+	const BYTE_FORMAT_ADJUST = 2;
+	const BYTE_FORMAT_SI = 4;
 	// control vars
 	/** @var bool compatible mode sets variable even if it is not defined */
 	private $set_compatible = true;
@@ -891,6 +895,42 @@ class Basic
 		return "<pre>".print_r($array, true)."</pre>";
 	}

+	/**
+	 * helper function for PHP file upload error messgaes to messge string
+	 * @param  int    $error_code integer _FILE upload error code
+	 * @return string                     message string, translated
+	 */
+	public function fileUploadErrorMessage(int $error_code): string
+	{
+		switch ($error_code) {
+			case UPLOAD_ERR_INI_SIZE:
+				$message = 'The uploaded file exceeds the upload_max_filesize directive in php.ini';
+				break;
+			case UPLOAD_ERR_FORM_SIZE:
+				$message = 'The uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the HTML form';
+				break;
+			case UPLOAD_ERR_PARTIAL:
+				$message = 'The uploaded file was only partially uploaded';
+				break;
+			case UPLOAD_ERR_NO_FILE:
+				$message = 'No file was uploaded';
+				break;
+			case UPLOAD_ERR_NO_TMP_DIR:
+				$message = 'Missing a temporary folder';
+				break;
+			case UPLOAD_ERR_CANT_WRITE:
+				$message = 'Failed to write file to disk';
+				break;
+			case UPLOAD_ERR_EXTENSION:
+				$message = 'File upload stopped by extension';
+				break;
+			default:
+				$message = 'Unknown upload error';
+				break;
+		}
+		return $message;
+	}
+
 	// ****** DEBUG/ERROR FUNCTIONS ******

 	// ****** RANDOM KEY GEN ******
@@ -1174,7 +1214,7 @@ class Basic
 	public static function getFilenameEnding(string $filename): string
 	{
 		$page_temp = pathinfo($filename);
-		return $page_temp['extension'];
+		return isset($page_temp['extension']) ? $page_temp['extension'] : '';
 	}

 	/**
@@ -1200,12 +1240,22 @@ class Basic
 			$path[] = $key_lookin;
 		} else {
 			foreach ($haystack as $key => $val) {
-				if (is_scalar($val) && $val === $needle && empty($key_lookin)) {
-					break;
-				} elseif (is_scalar($val) && !empty($key_lookin) && $key === $key_lookin && $val == $needle) {
+				if (is_scalar($val) &&
+					$val === $needle &&
+					empty($key_lookin)
+				) {
 					$path[] = $key;
 					break;
-				} elseif (is_array($val) && $path = Basic::arraySearchRecursive($needle, $val, $key_lookin)) {
+				} elseif (is_scalar($val) &&
+					!empty($key_lookin) &&
+					$key === $key_lookin &&
+					$val == $needle
+				) {
+					$path[] = $key;
+					break;
+				} elseif (is_array($val) &&
+					$path = Basic::arraySearchRecursive($needle, $val, $key_lookin)
+				) {
 					array_unshift($path, $key);
 					break;
 				}
@@ -1224,16 +1274,27 @@ class Basic
 	 */
 	public static function arraySearchRecursiveAll($needle, array $haystack, $key, $path = null): ?array
 	{
+		// init if not set on null
+		if ($path === null) {
+			$path = array(
+				'level' => 0,
+				'work' => array()
+			);
+		}
+		// init sub sets if not set
 		if (!isset($path['level'])) {
 			$path['level'] = 0;
 		}
 		if (!isset($path['work'])) {
 			$path['work'] = array();
 		}
+		// should not be needed because it would trigger a php mehtod error
 		if (!is_array($haystack)) {
 			$haystack = array();
 		}

+		// @phan HACK
+		$path['level'] = $path['level'] ?? 0;
 		// go through the array,
 		foreach ($haystack as $_key => $_value) {
 			if (is_scalar($_value) && $_value == $needle && !$key) {
@@ -1253,6 +1314,9 @@ class Basic
 				$path = Basic::arraySearchRecursiveAll($needle, $_value, $key, $path);
 			}
 		}
+		// @phan HACK
+		$path['level'] = $path['level'] ?? 0;
+		$path['work'] = $path['work'] ?? array();
 		// cut all that is >= level
 		array_splice($path['work'], $path['level']);
 		// step back a level
@@ -1344,6 +1408,21 @@ class Basic
 		return $merged;
 	}

+	/**
+	 * correct array_diff that does an actualy difference between two arrays.
+	 * array_diff only checks elements from A that are not in B, but not the
+	 * other way around.
+	 * Note that like array_diff this only checks first level values not keys
+	 * @param  array  $a array to compare a
+	 * @param  array  $b array to compare b
+	 * @return array     array with missing elements from a & b
+	 */
+	public static function arrayDiff(array $a, array $b): array
+	{
+		$intersect = array_intersect($a, $b);
+		return array_merge(array_diff($a, $intersect), array_diff($b, $intersect));
+	}
+
 	/**
 	 * search for the needle array elements in haystack and return the ones found as an array,
 	 * is there nothing found, it returns FALSE (boolean)
@@ -1517,20 +1596,117 @@ class Basic
 	}

 	/**
+	 * WRAPPER call to new humanReadableByteFormat
 	 * converts bytes into formated string with KB, MB, etc
-	 * @param  string|int|float $number bytes as string int or pure int
-	 * @param  bool             $space  true (default) to add space between number and suffix
+	 * @param  string|int|float $bytes  bytes as string int or pure int
+	 * @param  bool             $space  default true, to add space between number and suffix
+	 * @param  bool             $adjust default false, always print two decimals (sprintf)
+	 * @param  bool             $si     default false, if set to true, use 1000 for calculation
 	 * @return string                   converted byte number (float) with suffix
+	 * @deprecated Use humanReadableByteFormat instead
 	 */
-	public static function byteStringFormat($number, bool $space = true): string
+	public static function byteStringFormat($bytes, bool $space = true, bool $adjust = false, bool $si = false): string
 	{
-		if (is_numeric($number) && $number > 0) {
-			// labels in order of size
-			$labels = array('B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB');
-			// calc file size, round down too two digits, add label based max change
-			return round((float)$number / pow(1024, ($i = floor(log((float)$number, 1024)))), 2).($space ? ' ' : '').(isset($labels[(int)$i]) ? $labels[(int)$i] : '>EB');
+		// trigger_error('Method '.__METHOD__.' is deprecated, use humanReadableByteFormat', E_USER_DEPRECATED);
+		$flags = 0;
+		// match over the true/false flags to the new int style flag
+		// if space need to set 1
+		if ($space === false) {
+			$flags |= self::BYTE_FORMAT_NOSPACE;
+		}
+		// if adjust need to set 2
+		if ($adjust === true) {
+			$flags |= self::BYTE_FORMAT_ADJUST;
+		}
+		// if si need to set 3
+		if ($si === true) {
+			$flags |= self::BYTE_FORMAT_SI;
+		}
+
+		// call
+		return self::humanReadableByteFormat($bytes, $flags);
+	}
+
+
+	/**
+	 * This function replaces the old byteStringFormat
+	 *
+	 * Converts any number string to human readable byte format
+	 * Maxium is Exobytes and above that the Exobytes suffix is used for all
+	 * If more are needed only the correct short name for the suffix has to be
+	 * added to the labels array
+	 * On no number string it returns string as is
+	 * Source Idea: SOURCE: https://programming.guide/worlds-most-copied-so-snippet.html
+	 *
+	 * The class itself hast the following defined
+	 * BYTE_FORMAT_NOSPACE [1] turn off spaces between number and extension
+	 * BYTE_FORMAT_ADJUST  [2] use sprintf to always print two decimals
+	 * BYTE_FORMAT_SI      [3] use si standard 1000 instead of bytes 1024
+	 * To use the constant from outside use $class::CONSTANT
+	 * @param  string|int|float $bytes bytes as string int or pure int
+	 * @param  int              $flags bitwise flag with use space turned on
+	 * @return string                  converted byte number (float) with suffix
+	 */
+	public static function humanReadableByteFormat($bytes, int $flags = 0): string
+	{
+		// if not numeric, return as is
+		if (is_numeric($bytes)) {
+			// flags bit wise check
+			// remove space between number and suffix
+			if ($flags & self::BYTE_FORMAT_NOSPACE) {
+				$space = false;
+			} else {
+				$space = true;
+			}
+			// use sprintf instead of round
+			if ($flags & self::BYTE_FORMAT_ADJUST) {
+				$adjust = true;
+			} else {
+				$adjust = false;
+			}
+			// use SI 1000 mod and not 1024 mod
+			if ($flags & self::BYTE_FORMAT_SI) {
+				$si = true;
+			} else {
+				$si = false;
+			}
+
+			// si or normal
+			$unit = $si ? 1000 : 1024;
+			// always positive
+			$abs_bytes = $bytes == PHP_INT_MIN ? PHP_INT_MAX : abs($bytes);
+			// smaller than unit is always B
+			if ($abs_bytes < $unit) {
+				return $bytes.'B';
+			}
+			// labels in order of size [Y, Z]
+			$labels = array('', 'K', 'M', 'G', 'T', 'P', 'E');
+			// exp position calculation
+			$exp = floor(log($abs_bytes, $unit));
+			// avoid printing out anything larger than max labels
+			if ($exp >= count($labels)) {
+				$exp = count($labels) - 1;
+			}
+			// deviation calculation
+			$dev = pow($unit, $exp) * ($unit - 0.05);
+			// shift the exp +1 for on the border units
+			if ($exp < 6 &&
+				$abs_bytes > ($dev - (((int)$dev & 0xfff) == 0xd00 ? 52 : 0))
+			) {
+				$exp ++;
+			}
+			// label name, including leading space if flagged
+			$pre = ($space ? ' ' : '').(isset($labels[$exp]) ? $labels[$exp] : '>E').($si ? 'i' : '').'B';
+			$bytes_calc = $abs_bytes / pow($unit, $exp);
+			if ($adjust) {
+				return sprintf("%.2f%sB", $bytes_calc, $pre);
+			} else {
+				return round($bytes_calc, 2).$pre;
+			}
+		} else {
+			// if anything other return as string
+			return (string)$bytes;
 		}
-		return (string)$number;
 	}

 	/**
--- a/www/lib/CoreLibs/DB/IO.php
+++ b/www/lib/CoreLibs/DB/IO.php
@@ -1779,16 +1779,30 @@ class IO extends \CoreLibs\Basic
 				'row' => $table.'_id',
 				'value' => $primary_key
 			);
-		} elseif (!isset($primary_key['value'])) {
-			$primary_key['value'] = '';
+		} else {
+			if (!isset($primary_key['row'])) {
+				$primary_key['row'] = '';
+			}
+			if (!isset($primary_key['value'])) {
+				$primary_key['value'] = '';
+			}
 		}
 		// var set for strings
 		$q_sub_value = '';
 		$q_sub_data = '';
 		// get the table layout and row types
 		$table_data = $this->dbShowTableMetaData(($this->db_schema ? $this->db_schema.'.' : '').$table);
+		// @phan HACK
+		$primary_key['value'] = $primary_key['value'] ?? '';
+		$primary_key['row'] = $primary_key['row'] ?? '';
+		// loop through the write array and each field to build the query
 		foreach ($write_array as $field) {
-			if ((!$primary_key['value'] || ($primary_key['value'] && !in_array($field, $not_write_update_array))) && !in_array($field, $not_write_array)) {
+			if ((!$primary_key['value'] ||
+					($primary_key['value'] &&
+					!in_array($field, $not_write_update_array))
+				) &&
+				!in_array($field, $not_write_array)
+			) {
 				// data from external or data field
 				$_data = null;
 				if (count($data) >= 1 && array_key_exists($field, $data)) {
@@ -1842,7 +1856,7 @@ class IO extends \CoreLibs\Basic
 		}

 		// first work contact itself (we need contact id for everything else)
-		if ($primary_key['value']) {
+		if ($primary_key['value'] && $primary_key['row']) {
 			$q = 'UPDATE '.$table.' SET ';
 			$q .= $q_sub_data.' ';
 			$q .= 'WHERE '.$primary_key['row'].' = '.$primary_key['value'];
@@ -1861,8 +1875,8 @@ class IO extends \CoreLibs\Basic
 		if (!$primary_key['value']) {
 			$primary_key['value'] = $this->insert_id;
 		}
-
-		return $primary_key['value'];
+		// if there is not priamry key value field return false
+		return isset($primary_key['value']) ? $primary_key['value'] : false;
 	}

 	/**
--- a/www/lib/CoreLibs/Output/Form/Generate.php
+++ b/www/lib/CoreLibs/Output/Form/Generate.php
@@ -242,6 +242,11 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 	public $security_level;
 	// layout publics
 	public $table_width;
+	// internal lang & encoding vars
+	public $lang_dir = '';
+	public $lang;
+	public $lang_short;
+	public $encoding;
 	// language
 	public $l;

@@ -251,15 +256,15 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 	/**
 	 * construct form generator
 	 * @param array       $db_config        db config array
-	 * @param string      $lang             interface language
 	 * @param int|integer $table_width      table/div width (default 750)
 	 * @param int|integer $set_control_flag basic class set/get variable error flags
 	 */
-	public function __construct(array $db_config, string $lang, int $table_width = 750, int $set_control_flag = 0)
+	public function __construct(array $db_config, int $table_width = 750, int $set_control_flag = 0)
 	{
 		$this->my_page_name = $this->getPageName(1);
+		$this->setLangEncoding();
 		// init the language class
-		$this->l = new \CoreLibs\Language\L10n($lang);
+		$this->l = new \CoreLibs\Language\L10n($this->lang);
 		// load config array
 		// get table array definitions for current page name
 		// WARNING: auto spl load does not work with this as it is an array and not a function/object
@@ -323,18 +328,28 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 		$this->base_acl_level = isset($_SESSION['BASE_ACL_LEVEL']) ? $_SESSION['BASE_ACL_LEVEL'] : 0;
 		// security levels for buttons/actions
 		// if array does not exists create basic
-		if (!isset($config_array['security_level']) || !is_array($config_array['security_level']) ||
-			(is_array($config_array['security_level']) && count($config_array['security_level']) < 4)
+		if (!isset($config_array['security_level']) ||
+			(isset($config_array['security_level']) &&
+				(!is_array($config_array['security_level']) ||
+				(is_array($config_array['security_level']) && count($config_array['security_level']) < 4))
+			)
 		) {
-			$config_array['security_level'] = array(
+			$this->security_level = array(
 				'load' => 100,
 				'new' => 100,
 				'save' => 100,
 				'delete' => 100
 			);
+		} else {
+			// write array to class var
+			$this->security_level = isset($config_array['security_level']) ?
+				$config_array['security_level'] :
+				array('load' => 100,
+					'new' => 100,
+					'save' => 100,
+					'delete' => 100
+				);
 		}
-		// write array to class var
-		$this->security_level = $config_array['security_level'];
 	}

 	/**
@@ -348,6 +363,45 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 		parent::__destruct();
 	}

+	// INTERNAL METHODS |===============================================>
+
+	/**
+	 * ORIGINAL in \CoreLibs\Admin\Backend
+	 * set the language encoding and language settings
+	 * the default charset from _SESSION login or from
+	 * config DEFAULT ENCODING
+	 * the lang full name for mo loading from _SESSION login
+	 * or SITE LANG or DEFAULT LANG from config
+	 * creates short lang (only first two chars) from the lang
+	 * @return void
+	 */
+	private function setLangEncoding(): void
+	{
+		// just emergency fallback for language
+		// set encoding
+		if (isset($_SESSION['DEFAULT_CHARSET'])) {
+			$this->encoding = $_SESSION['DEFAULT_CHARSET'];
+		} else {
+			$this->encoding = DEFAULT_ENCODING;
+		}
+		// gobal override
+		if (isset($GLOBALS['OVERRIDE_LANG'])) {
+			$this->lang = $GLOBALS['OVERRIDE_LANG'];
+		} elseif (isset($_SESSION['DEFAULT_LANG'])) {
+			// session (login)
+			$this->lang = $_SESSION['DEFAULT_LANG'];
+		} else {
+			// mostly default SITE LANG or DEFAULT LANG
+			$this->lang = defined('SITE_LANG') ? SITE_LANG : DEFAULT_LANG;
+		}
+		// create the char lang encoding
+		$this->lang_short = substr($this->lang, 0, 2);
+		// set the language folder
+		$this->lang_dir = BASE.INCLUDES.LANG.CONTENT_PATH;
+	}
+
+	// PUBLIC METHODS |=================================================>
+
 	/**
 	 * dumps all values into output (for error msg)
 	 * @return string full table array data output as string html formatted
@@ -442,7 +496,11 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 	 */
 	public function formProcedureLoad(string $archive_id): void
 	{
-		if ($this->archive && $archive_id && $this->base_acl_level >= $this->security_level['load']) {
+		if (isset($this->security_level['load']) &&
+			$this->archive &&
+			$archive_id &&
+			$this->base_acl_level >= $this->security_level['load']
+		) {
 			$this->formLoadTableArray($archive_id);
 			$this->yes = 1;
 		}
@@ -454,7 +512,10 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 	 */
 	public function formProcedureNew(): void
 	{
-		if ($this->new && $this->base_acl_level >= $this->security_level['new']) {
+		if (isset($this->security_level['new']) &&
+			$this->new &&
+			$this->base_acl_level >= $this->security_level['new']
+		) {
 			if ($this->really_new == 'yes') {
 				$this->formUnsetTablearray();
 			} else {
@@ -471,7 +532,10 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 	 */
 	public function formProcedureSave(): void
 	{
-		if ($this->save && $this->base_acl_level >= $this->security_level['save']) {
+		if (isset($this->security_level['save']) &&
+			$this->save &&
+			$this->base_acl_level >= $this->security_level['save']
+		) {
 			$this->formErrorCheck();
 			if (!$this->error) {
 				$this->formSaveTableArray();
@@ -487,7 +551,10 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 	public function formProcedureDelete(): void
 	{
 		// delete is also by 'protected'
-		if ($this->delete && $this->base_acl_level >= $this->security_level['delete']) {
+		if (isset($this->security_level['delete']) &&
+			$this->delete &&
+			$this->base_acl_level >= $this->security_level['delete']
+		) {
 			if (isset($this->table_array['protected']['value']) && $this->table_array['protected']['value']) {
 				$this->msg .= $this->l->__('Cannot delete this Dataset, because it is internaly protected!');
 				$this->error = 2;
@@ -510,11 +577,13 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 	 */
 	public function formProcedureDeleteFromElementList(array $element_list, array $remove_name): void
 	{
+		/** @phan-suppress-next-line PhanTypeArraySuspiciousNullable */
 		$this->debug('REMOVE ELEMENT', 'Remove REF ELEMENT: '.$this->base_acl_level.' >= '.$this->security_level['delete']);
 		$this->debug('REMOVE ELEMENT', 'Protected Value set: '.(string)isset($this->table_array['protected']['value']));
 		$this->debug('REMOVE ELEMENT', 'Error: '.$this->error);
 		// only do if the user is allowed to delete
-		if ($this->base_acl_level >= $this->security_level['delete'] &&
+		if (isset($this->security_level['delete']) &&
+			$this->base_acl_level >= $this->security_level['delete'] &&
 			(!isset($this->table_array['protected']['value']) ||
 			(isset($this->table_array['protected']['value']) && !$this->table_array['protected']['value'])) &&
 			!$this->error
@@ -597,7 +666,9 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 		$pk_names = array();
 		$pk_ids = array();
 		// when security level is okay ...
-		if ($this->base_acl_level >= $this->security_level['load']) {
+		if (isset($this->security_level['load']) &&
+			$this->base_acl_level >= $this->security_level['load']
+		) {
 			$t_pk_name = $this->archive_pk_name;

 			// load list data
@@ -610,17 +681,24 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 					$pk_selected = $res[$this->int_pk_name];
 				}
 				$t_string = '';
-				for ($i = 0, $i_max = count($this->field_array); $i < $i_max; $i ++) {
+				foreach ($this->field_array as $i => $field_array) {
 					if ($t_string) {
 						$t_string .= ', ';
 					}
-					if (isset($this->field_array[$i]['before_value'])) {
-						$t_string .= $this->field_array[$i]['before_value'];
+					if (isset($field_array['before_value'])) {
+						$t_string .= $field_array['before_value'];
 					}
-					if (isset($this->field_array[$i]['binary'])) {
-						$t_string .= ($res[$this->field_array[$i]['name']]) ? $this->field_array[$i]['binary'][0] : $this->field_array[$i]['binary'][1];
-					} else {
-						$t_string .= $res[$this->field_array[$i]['name']];
+					// must have res element set
+					if (isset($res[$field_array['name']])) {
+						if (isset($field_array['binary'])) {
+							if (isset($field_array['binary'][0])) {
+								$t_string .= $field_array['binary'][0];
+							} elseif (isset($field_array['binary'][1])) {
+								$t_string .= $field_array['binary'][1];
+							}
+						} else {
+							$t_string .= $res[$field_array['name']];
+						}
 					}
 				}
 				$pk_names[] = $t_string;
@@ -644,7 +722,9 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 		$show_checkbox = 0;
 		$new_name = '';
 		// when security level is okay
-		if ($this->base_acl_level >= $this->security_level['new']) {
+		if (isset($this->security_level['new']) &&
+			$this->base_acl_level >= $this->security_level['new']
+		) {
 			if ($this->yes && !$hide_new_checkbox) {
 				$show_checkbox = 1;
 			}
@@ -675,7 +755,11 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 		$pk_value = '';
 		$show_delete = 0;
 		$old_school_hidden = 0;
-		if ($this->base_acl_level >= $this->security_level['save'] || $this->base_acl_level >= $this->security_level['delete']) {
+		if ((isset($this->security_level['save']) &&
+				$this->base_acl_level >= $this->security_level['save']) ||
+			(isset($this->security_level['delete']) &&
+				$this->base_acl_level >= $this->security_level['delete'])
+		) {
 			$old_school_hidden = 0;
 			if ($this->base_acl_level >= $this->security_level['save']) {
 				$seclevel_okay = 1;
@@ -899,7 +983,7 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 			$data['value'] = isset($this->table_array[$element_name]['value']) ? $this->table_array[$element_name]['value'] : 0;
 			$data['col_name'] = $this->col_name;
 			$data['table_name'] = $this->table_name;
-			$data['query'] = urlencode($query);
+			$data['query'] = $query !== null ? urlencode($query) : '';
 		}
 		// file upload
 		if ($this->table_array[$element_name]['type'] == 'file') {
@@ -1590,13 +1674,28 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 					$q = '';
 					// skip empty or not fully filled rows
 					if (isset($no_write[$i]) && !$no_write[$i]) {
+						if (!isset($q_begin[$i])) {
+							$q_begin[$i] = '';
+						}
+						if (!isset($q_end[$i])) {
+							$q_end[$i] = '';
+						}
 						// if tpye is update
-						if ($type[$i] == 'update') {
-							$q = $q_begin[$i].$q_data[$i].$q_end[$i];
+						if (isset($type[$i]) && $type[$i] == 'update') {
+							$q = $q_begin[$i].
+								(isset($q_data[$i]) ? $q_data[$i] : '').
+								$q_end[$i];
 						// or if we have block write, then it is insert (new)
 						} elseif (isset($block_write[$i]) && $block_write[$i]) {
-							$q = $q_begin[$i].$q_names[$i].', '.$this->int_pk_name.$q_middle[$i].$q_values[$i].', '.$this->table_array[$this->int_pk_name]['value'].$q_end[$i];
+							$q = $q_begin[$i].
+								(isset($q_names[$i]) ? $q_names[$i] : '').', '.
+								$this->int_pk_name.
+								(isset($q_middle[$i]) ? $q_middle[$i] : '').
+								(isset($q_values[$i]) ? $q_values[$i] : '').', '.
+								$this->table_array[$this->int_pk_name]['value'].
+								$q_end[$i];
 						}
+						/** @phan-suppress-next-line PhanTypePossiblyInvalidDimOffset */
 						$this->debug('edit', 'Pos['.$i.'] => '.$type[$i].' Q: '.$q.'<br>');
 						// write the dataset
 						if ($q) {
@@ -1724,7 +1823,23 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 	 */
 	public function formCreateElementListTable(string $table_name): array
 	{
-		$data = array();
+		// init data rray
+		$data = array(
+			'delete_name' => '',
+			'delete' => 0,
+			'enable_name' => '',
+			'prefix' => '',
+			'pk_name' => '',
+			'fk_name' => '',
+			'type' => array(),
+			'output_name' => array(),
+			'preset' => array(),
+			'element_list' => array(),
+			'output_data' => array(),
+			'content' => array(),
+			'pos' => array(),
+			'table_name' => $table_name // sub table name
+		);
 		// output name for the viewable left table td box, prefixed with * if mandatory
 		$output_name = $this->element_list[$table_name]['output_name'];
 		if (isset($this->element_list[$table_name]['mandatory']) &&
@@ -1735,8 +1850,6 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 		// delete button name, if there is one set
 		if (isset($this->element_list[$table_name]['delete_name'])) {
 			$data['delete_name'] = $this->element_list[$table_name]['delete_name'];
-		} else {
-			$data['delete_name'] = '';
 		}
 		// set the enable checkbox for delete, if the delete flag is given if there is one
 		if (isset($this->element_list[$table_name]['enable_name'])) {
@@ -1744,17 +1857,11 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 			if (isset($this->element_list[$table_name]['delete'])) {
 				$data['delete'] = 1;
 			}
-		} else {
-			$data['enable_name'] = '';
 		}
 		// prefix for the elements, to not collide with names in the master set
 		if (isset($this->element_list[$table_name]['prefix'])) {
 			$data['prefix'] = $this->element_list[$table_name]['prefix'].'_';
-		} else {
-			$data['prefix'] = '';
 		}
-		// the sub data table name
-		$data['table_name'] = $table_name;

 		// build the select part
 		if (!isset($this->element_list[$table_name]['elements']) || !is_array($this->element_list[$table_name]['elements'])) {
@@ -1788,10 +1895,11 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 			if (isset($data_array['type']) && $data_array['type'] == 'drop_down_db') {
 				$md_q = md5($data_array['query']);
 				while ($res = $this->dbReturn($data_array['query'])) {
+					/** @phan-suppress-next-line PhanTypeInvalidDimOffset */
 					$this->debug('edit', 'Q['.$md_q.'] pos: '.$this->cursor_ext[$md_q]['pos'].' | want: '.(isset($data_array['preset']) ? $data_array['preset'] : '-').' | set: '.(isset($data['preset'][$el_name]) ? $data['preset'][$el_name] : '-'));
 					// first is default for this element
 					if (isset($data_array['preset']) &&
-						(!isset($data['preset'][$el_name]) || (isset($data['preset'][$el_name]) && !$data['preset'][$el_name])) &&
+						(!isset($data['preset'][$el_name]) || empty($data['preset'][$el_name])) &&
 						($this->cursor_ext[$md_q]['pos'] == $data_array['preset'])
 					) {
 						$data['preset'][$el_name] = $res[0];
@@ -1840,6 +1948,8 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 					array_unshift($q_select, $read_name);
 				}
 			}
+			// @phan HACK
+			$data['prefix'] = $data['prefix'] ?? '';
 			// set the rest of the data so we can print something out
 			$data['type'][$data['prefix'].$this->element_list[$table_name]['read_data']['name']] = 'string';
 			// build the read query
@@ -1875,7 +1985,7 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 			// read out the list and add the selected data if needed
 			while ($res = $this->dbReturn($q)) {
 				$_data = array();
-				$prfx = $data['prefix']; // short
+				$prfx = $data['prefix'] ?? ''; // short
 				// go through each res
 				for ($i = 0, $i_max = count($q_select); $i < $i_max; $i ++) {
 					// query select part, set to the element name
@@ -1923,15 +2033,23 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 			$missing_empty_count = $this->element_list[$table_name]['max_empty'] - $element_count;
 			$this->debug('CFG MAX', 'Max empty: '.$this->element_list[$table_name]['max_empty'].', Missing: '.$missing_empty_count.', Has: '.$element_count);
 			// set if we need more open entries or if we do not have any entries yet
-			if (($missing_empty_count < $this->element_list[$table_name]['max_empty']) || $element_count == 0) {
+			if (($missing_empty_count < $this->element_list[$table_name]['max_empty']) ||
+				$element_count == 0
+			) {
 				for ($pos = $element_count, $pos_max = $this->element_list[$table_name]['max_empty'] + $element_count; $pos <= $pos_max; $pos ++) {
 					$_data = array();
+					// just in case
+					if (!isset($data['type'])) {
+						$data['type'] = array();
+					}
 					// the fields that need to be filled are in data->type array:
 					// pk fields are unfilled
 					// fk fields are filled with the fk_id 'int_pk_name' value
 					foreach ($data['type'] as $el_name => $type) {
 						$_data[$el_name] = '';
-						if ($el_name == $data['pk_name']) {
+						if (isset($data['pk_name']) &&
+							$el_name == $data['pk_name']
+						) {
 							// do nothing for pk name
 						} elseif (isset($data['fk_name']) &&
 							$el_name == $data['fk_name'] &&
@@ -1941,8 +2059,11 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 						}
 					}
 					$data['content'][] = $_data;
-					$data['pos'][] = array(0 => $pos); // this is for the checkboxes
-					// $this->debug('CFG ELEMENT LIST FILL', 'Pos: '.$pos.'/'.$pos_max.', Content: '.count($data['content']).', Pos: '.count($data['pos']));
+					// this is for the checkboxes
+					$data['pos'][] = array(
+						0 => $pos
+					);
+					$this->debug('CFG ELEMENT LIST FILL', 'Pos: '.$pos.'/'.$pos_max.', Content: '.count($data['content']).', Pos: '.count($data['pos']));
 				}
 			}
 		}
--- a/www/lib/CoreLibs/Template/SmartyExtend.php
+++ b/www/lib/CoreLibs/Template/SmartyExtend.php
@@ -89,10 +89,9 @@ class SmartyExtend extends SmartyBC
 	/**
 	 * constructor class, just sets the language stuff
 	 * calls L10 for pass on internaly in smarty
-	 * also registers the getvar caller pliugin
-	 * @param string $lang language string to set
+	 * also registers the getvar caller plugin
 	 */
-	public function __construct(string $lang)
+	public function __construct()
 	{
 		// call basic smarty
 		parent::__construct();
@@ -121,7 +120,7 @@ class SmartyExtend extends SmartyBC
 	 * creates short lang (only first two chars) from the lang
 	 * @return void
 	 */
-	public function setLangEncoding(): void
+	private function setLangEncoding(): void
 	{
 		// just emergency fallback for language
 		// set encoding
@@ -130,10 +129,14 @@ class SmartyExtend extends SmartyBC
 		} else {
 			$this->encoding = DEFAULT_ENCODING;
 		}
-		// just emergency fallback for language
-		if (isset($_SESSION['DEFAULT_LANG'])) {
+		// gobal override
+		if (isset($GLOBALS['OVERRIDE_LANG'])) {
+			$this->lang = $GLOBALS['OVERRIDE_LANG'];
+		} elseif (isset($_SESSION['DEFAULT_LANG'])) {
+			// session (login)
 			$this->lang = $_SESSION['DEFAULT_LANG'];
 		} else {
+			// mostly default SITE LANG or DEFAULT LANG
 			$this->lang = defined('SITE_LANG') ? SITE_LANG : DEFAULT_LANG;
 		}
 		// create the char lang encoding
@@ -277,12 +280,7 @@ class SmartyExtend extends SmartyBC
 	private function setSmartyVars($admin_call = false): void
 	{
 		global $cms;
-		// array merge HEADER, DATA, DEBUG DATA
-		foreach (array('HEADER', 'DATA', 'DEBUG_DATA') as $ext_smarty) {
-			if (is_array($cms->{$ext_smarty})) {
-				$this->{$ext_smarty} = array_merge($this->{$ext_smarty}, $cms->{$ext_smarty});
-			}
-		}
+		$this->mergeCmsSmartyVars($cms);

 		// trigger flags
 		$this->HEADER['USE_PROTOTYPE'] = $this->USE_PROTOTYPE;
@@ -389,7 +387,31 @@ class SmartyExtend extends SmartyBC
 		$this->DATA['CONTENT_INCLUDE'] = $this->CONTENT_INCLUDE;
 		$this->DATA['TEMPLATE_TRANSLATE'] = isset($this->TEMPLATE_TRANSLATE) ? $this->TEMPLATE_TRANSLATE : null;
 		$this->DATA['PAGE_FILE_NAME'] = str_replace('.php', '', $this->page_name).'.tpl';
+		// render page
+		$this->renderSmarty();
+	}

+	/**
+	 * merge outside object HEADER/DATA/DEBUG_DATA vars into the smarty class
+	 * @param  object $cms object that has header/data/debug_data
+	 * @return void
+	 */
+	public function mergeCmsSmartyVars(object $cms): void
+	{
+		// array merge HEADER, DATA, DEBUG DATA
+		foreach (array('HEADER', 'DATA', 'DEBUG_DATA') as $ext_smarty) {
+			if (is_array($cms->{$ext_smarty})) {
+				$this->{$ext_smarty} = array_merge($this->{$ext_smarty}, $cms->{$ext_smarty});
+			}
+		}
+	}
+
+	/**
+	 * render smarty data (can be called sepparate)
+	 * @return void
+	 */
+	public function renderSmarty(): void
+	{
 		// create main data array
 		$this->CONTENT_DATA = array_merge($this->HEADER, $this->DATA, $this->DEBUG_DATA);
 		// data is 1:1 mapping (all vars, values, etc)
Author	SHA1	Message	Date
Clemens Schwaighofer	b6f6eeac9b	Update byteStringFormat with si units and bitwise mask The old method name byteStringFormat is currently deprecated and it is recommended to move to the new humanReadableByteFormat method. Difference is that the new version uses a bitfield settings mask BYTE_FORMAT_NOSPACE, BYTE_FORMAT_ADJUST, BYTE_FORMAT_SI	2019-12-06 15:29:06 +09:00
Clemens Schwaighofer	beedf629e5	Fixups for phan 2.4.4 run checks Lines with @phan HACK comment are added to supress phan warnings, but do actually no additional work. On newer phan version those lines should be checked and removed if needed	2019-12-05 16:01:44 +09:00
Clemens Schwaighofer	04b47574eb	CoreLibs\Basic arrayDiff for full array diff PHP array_diff only compares missing elements in the second and existing in the first so a full diff is only achieved if compares both ways (a,b) and (b,a) This function uns a full compare and returns difference in an array	2019-12-04 12:12:43 +09:00
Clemens Schwaighofer	ecc52e2dbd	Basic class if layout fixes	2019-11-28 15:44:39 +09:00
Clemens Schwaighofer	12e335c69c	Move fileUploadErrorMessage from Admin\Backend to Basic Also removed the auto translate, return just string. Is also a static method so can be called by Basic::fileUploadErrorMessage too Removed left over LANG settings in admin header	2019-11-15 17:53:21 +09:00
Clemens Schwaighofer	3ae3b1b761	Simplify language calls There are no more lang vars passed on to any class calls The new order is the following $OVERRIDE_LANG > _SESSION > SITE_LANG > DEFAULT_LANG Todo: make the setLang better so we do not have the same method in Backend/Generic/SmartyExtended	2019-11-15 17:07:35 +09:00
Clemens Schwaighofer	3c9ca025f5	Smarty Extended split out cms var merge & content render The down merge of outside class smarty vars is now an extra function that can be called stand alone. The smarty render function call is also a stand alone function that can be called from outside	2019-11-15 15:20:12 +09:00