Add Base class set/get variable error check, strict updates

The base class has now set/get class variable check handlers. Default they are off and setting undefined variables in a class works as before. The flag can be set to throw an error on an unset var but let var still be set or also surpress setting and unset var. This can be controlled via setting for the last parameter in class init or the global var $CLASS_VARIABLE_ERROR_MODE or in the config file the constant CLASS_VARIABLE_ERROR_MODE (constant > global). Note that if a global or constant is set the class constructor setting will be overridden. Backend/IO/Basic/Login classes are set to be type safe as much as possible if called from a strict defined php script. Added random key generator function to the basic class and removed the random key definitons from the Backend class. - randomKeyGen - initRandomKeyLength Updated the basic bytes to string and string to bytes functions. Added hrRunningTime method to use the hrtime for precise running time calculations. Default returns running time in ms. Can be set via parameter to ns (lowest), ys, ms, s. The old runningTime method is still there, but it is recommended to use the hrRunningTime method instead Removed Error Handling method in Basic, as there is no need for it there. The is a master one in lib Folder Error.Handling.inc if needed. Currently Generate/ArrayIO are not 100% type safe [because they are only used in the edit_base anyway]
2019-09-11 15:23:34 +09:00
parent 745faacb30
commit b25f280849
11 changed files with 630 additions and 318 deletions
--- a/www/admin/class_test.php
+++ b/www/admin/class_test.php
@@ -30,6 +30,15 @@ $basic = new CoreLibs\Admin\Backend($DB_CONFIG[MAIN_DB], $lang);
 $basic->dbInfo(1);
 ob_end_flush();

+$basic->hrRunningTime();
+$basic->runningTime();
+echo "RANDOM KEY [50]: ".$basic->randomKeyGen(50)."<br>";
+echo "TIMED [hr]: ".$basic->hrRunningTime()."<br>";
+echo "TIMED [def]: ".$basic->runningTime()."<br>";
+$basic->hrRunningTime();
+echo "RANDOM KEY [default]: ".$basic->randomKeyGen()."<br>";
+echo "TIMED: ".$basic->hrRunningTime()."<br>";
+
 // set + check edit access id
 $edit_access_id = 3;
 if (isset($login) && is_object($login) && isset($login->acl['unit'])) {
--- a/www/configs/config.inc
+++ b/www/configs/config.inc
@@ -146,6 +146,13 @@ DEFINE('DEFAULT_ENCODING', 'UTF-8');
 /************* LOGGING *******************/
 // DEFINE('LOG_FILE_ID', '');

+/************* CLASS ERRORS *******************/
+// 0 = default all OFF
+// 1 = throw notice on unset class var
+// 2 = no notice on unset class var, but do not set undefined class var
+// 3 = throw error and do not set class var
+define('CLASS_VARIABLE_ERROR_MODE', 3);
+
 /************* QUEUE TABLE *************/
 // if we have a dev/live system
 // set_live is a per page/per item
--- a/www/lib/CoreLibs/ACL/Login.inc
+++ b/www/lib/CoreLibs/ACL/Login.inc
@@ -78,6 +78,9 @@ class Login extends \CoreLibs\DB\IO
 	private $pw_new_password;
 	private $pw_new_password_confirm;
 	private $pw_change_deny_users = array (); // array of users for which the password change is forbidden
+	private $logout_target;
+	private $max_login_error_count = -1;
+	private $lock_deny_users = array ();

 	// if we have password change we need to define some rules
 	private $password_min_length = PASSWORD_MIN_LENGTH;
@@ -102,18 +105,21 @@ class Login extends \CoreLibs\DB\IO
 	public $acl = array ();
 	public $default_acl_list = array ();

+	// language
+	private $l;
+
 	// METHOD: login
 	// PARAMS: db_config -> array for logging in to DB where edit_users tables are
 	//        db_debug -> sets debug output for db_io (can be overruled with DB_DEBUG)
 	// RETURN: none
 	// DESC  : cunstroctuor, does ALL, opens db, works through connection checks, closes itself
-	public function __construct($db_config, $lang = 'en_utf8', $debug = 0, $db_debug = 0, $echo = 1, $print = 0)
+	public function __construct(array $db_config, string $lang = 'en_utf8', int $set_control_flag = 0)
 	{
 		// log login data for this class only
 		$this->log_per_class = 1;

 		// create db connection and init base class
-		if (!parent::__construct($db_config, $debug, $db_debug, $echo, $print)) {
+		if (!parent::__construct($db_config, $set_control_flag)) {
 			echo 'Could not connect to DB<br>';
 			// if I can't connect to the DB to auth exit hard. No access allowed
 			exit;
@@ -282,7 +288,7 @@ class Login extends \CoreLibs\DB\IO
 	// PARAMS: hash, optional password, to override
 	// RETURN: true or false
 	// DESC  : checks if password is valid, sets internal error login variable
-	private function loginPasswordCheck($hash, $password = '')
+	private function loginPasswordCheck(string $hash, string $password = ''): bool
 	{
 		// check with what kind of prefix the password begins:
 		// $2a$ or $2y$: BLOWFISCH
@@ -551,7 +557,9 @@ class Login extends \CoreLibs\DB\IO
 						$q .= "WHERE edit_user_id = ".$res['edit_user_id'];
 						$this->dbExec($q);
 						// totally lock the user if error max is reached
-						if ($res['login_error_count'] + 1 > $this->max_login_error_count) {
+						if ($this->max_login_error_count != -1 &&
+							$res['login_error_count'] + 1 > $this->max_login_error_count
+						) {
 							// do some alert reporting in case this error is too big
 							// if strict is set, lock this user
 							// this needs manual unlocking by an admin user
@@ -738,7 +746,7 @@ class Login extends \CoreLibs\DB\IO
 	// PARAMS: edit_access_id to check
 	// RETURN: true/false: if the edit access is not in the valid list: false
 	// DESC  : checks if this edit access id is valid
-	public function loginCheckEditAccess($edit_access_id)
+	public function loginCheckEditAccess($edit_access_id): bool
 	{
 		if (array_key_exists($edit_access_id, $this->acl['unit'])) {
 			return true;
@@ -773,7 +781,7 @@ class Login extends \CoreLibs\DB\IO
 	// PARAMS: set the minimum length
 	// RETURN: true/false on success
 	// DESC  : sets the minium length and checks on valid
-	public function loginSetPasswordMinLength($length)
+	public function loginSetPasswordMinLength(int $length): bool
 	{
 		// check that numeric, positive numeric, not longer than max input string lenght
 		// and not short than min password length
@@ -1176,7 +1184,13 @@ EOM;
 			}
 		}
 		$q .= "'".session_id()."', ";
-		$q .= "'".$this->dbEscapeString($this->action)."', '".$this->dbEscapeString($this->username)."', NULL, '".$this->dbEscapeString($this->login_error)."', NULL, NULL, '".$this->dbEscapeString($this->permission_okay)."', NULL)";
+		$q .= "'".$this->dbEscapeString($this->action)."', ";
+		$q .= "'".$this->dbEscapeString($this->username)."', ";
+		$q .= "NULL, ";
+		$q .= "'".$this->dbEscapeString((string)$this->login_error)."', ";
+		$q .= "NULL, NULL, ";
+		$q .= "'".$this->dbEscapeString((string)$this->permission_okay)."', ";
+		$q .= "NULL)";
 		$this->dbExec($q, 'NULL');
 	}

--- a/www/lib/CoreLibs/Admin/Backend.inc
+++ b/www/lib/CoreLibs/Admin/Backend.inc
@@ -27,7 +27,6 @@ namespace CoreLibs\Admin;
 class Backend extends \CoreLibs\DB\IO
 {
 	// page name
-	public $page_name; // the name of the current page
 	public $menu = array();
 	public $menu_show_flag = 0; // top menu flag (mostly string)
 	// action ids
@@ -43,6 +42,9 @@ class Backend extends \CoreLibs\DB\IO
 	public $action_error;
 	// ACL array variable if we want to set acl data from outisde
 	public $acl = array ();
+	public $default_acl;
+	// queue key
+	public $queue_key;
 	// the current active edit access id
 	public $edit_access_id;
 	// error/warning/info messages
@@ -55,15 +57,41 @@ class Backend extends \CoreLibs\DB\IO
 	public $HEADER;
 	public $DEBUG_DATA;
 	public $CONTENT_DATA;
+	// smarty include/set var
+	public $INC_TEMPLATE_NAME;
+	public $JS_TEMPLATE_NAME;
+	public $CSS_TEMPLATE_NAME;
+	public $CSS_SPECIAL_TEMPLATE_NAME;
+	public $JS_SPECIAL_TEMPLATE_NAME;
+	public $CACHE_ID;
+	public $COMPILE_ID;
+	public $includes;
+	public $template_path;
+	public $lang_dir;
+	public $javascript;
+	public $css;
+	public $pictures;
+	public $cache_pictures;
+	public $cache_pictures_root;
+	public $JS_INCLUDE;
+	public $JS_SPECIAL_INCLUDE;
+	public $CSS_INCLUDE;
+	public $CSS_SPECIAL_INCLUDE;
+	// language
+	public $l;

 	// CONSTRUCTOR / DECONSTRUCTOR |====================================>
-	public function __construct($db_config, $lang, $debug = 0, $db_debug = 0, $echo = 1, $print = 0)
+	// METHOD: __construct
+	// PARAMS: array db config
+	//         string for language set
+	//         int set control flag (for core basic set/get var error control)
+	public function __construct(array $db_config, string $lang, int $set_control_flag = 0)
 	{
 		// get the language sub class & init it
 		$this->l = new \CoreLibs\Language\L10n($lang);

 		// init the database class
-		parent::__construct($db_config, $debug, $db_debug, $echo, $print);
+		parent::__construct($db_config, $set_control_flag);

 		// internal
 		$this->class_info["adbBackend"] = array(
@@ -73,9 +101,6 @@ class Backend extends \CoreLibs\DB\IO
 			"class_author" => "Clemens Schwaighofer"
 		);

-		// set page name
-		$this->page_name = $this->getPageName();
-
 		// set the action ids
 		foreach ($this->action_list as $_action) {
 			$this->$_action = (isset($_POST[$_action])) ? $_POST[$_action] : '';
@@ -83,24 +108,9 @@ class Backend extends \CoreLibs\DB\IO

 		$this->default_acl = DEFAULT_ACL_LEVEL;

-		// random key generation
-		$this->key_range = array_merge(range('A', 'Z'), range('a', 'z'), range('0', '9'));
-		$GLOBALS["_KEY_RANGE"] = $this->key_range;
-		$this->one_key_length = count($this->key_range);
-		$this->key_length = 4; // pow($this->one_key_length, 4); // hardcoded, should be more than enought (62*62*62*62)
-
 		// queue key
 		if (preg_match("/^(add|save|delete|remove|move|up|down|push_live)$/", $this->action)) {
-			$this->queue_key = join(
-				'',
-				array_map(
-					function () {
-						$range = $GLOBALS['_KEY_RANGE'];
-						return $range[rand(0, (count($range) - 1))];
-					},
-					range(1, 3)
-				)
-			);
+			$this->queue_key = $this->randomKeyGen(3);
 		}
 	}

@@ -116,16 +126,18 @@ class Backend extends \CoreLibs\DB\IO
 	// PUBLIC METHODS |=================================================>

 	// METHOD: adbEditLog()
-	// PARAMS: event -> any kind of event description, data -> any kind of data related to that event
+	// PARAMS: event -> any kind of event description,
+	//         data -> any kind of data related to that event
 	// RETURN: none
 	// DESC  : writes all action vars plus other info into edit_log table
-	public function adbEditLog($event = '', $data = '', $write_type = 'STRING')
+	public function adbEditLog(string $event = '', $data = '', string $write_type = 'STRING')
 	{
 		if ($write_type == 'BINARY') {
 			$data_binary = $this->dbEscapeBytea(bzcompress(serialize($data)));
 			$data = 'see bzip compressed data_binary field';
 		}
 		if ($write_type == 'STRING') {
+			$data_binary = '';
 			$data = $this->dbEscapeString(serialize($data));
 		}

@@ -134,17 +146,27 @@ class Backend extends \CoreLibs\DB\IO
 		$q .= "ip, user_agent, referer, script_name, query_string, server_name, http_host, http_accept, http_accept_charset, http_accept_encoding, session_id, ";
 		$q .= "action, action_id, action_yes, action_flag, action_menu, action_loaded, action_value, action_error) ";
 		$q .= "VALUES ";
-		$q .= "(".@$_SESSION['EUID'].", NOW(), '".$this->dbEscapeString($event)."', '".$data."', '".$data_binary."', '".$this->page_name."', ";
+		$q .= "(".$this->dbEscapeString(isset($_SESSION['EUID']) ? $_SESSION['EUID'] : '').", ";
+		$q .= "NOW(), ";
+		$q .= "'".$this->dbEscapeString($event)."', '".$data."', '".$data_binary."', '".$this->dbEscapeString($this->page_name)."', ";
 		$q .= "'".@$_SERVER["REMOTE_ADDR"]."', '".$this->dbEscapeString(@$_SERVER['HTTP_USER_AGENT'])."', ";
-		$q .= "'".$this->dbEscapeString(@$_SERVER['HTTP_REFERER'])."', '".$this->dbEscapeString(@$_SERVER['SCRIPT_FILENAME'])."', ";
-		$q .= "'".$this->dbEscapeString(@$_SERVER['QUERY_STRING'])."', '".$this->dbEscapeString(@$_SERVER['SERVER_NAME'])."', ";
-		$q .= "'".$this->dbEscapeString(@$_SERVER['HTTP_HOST'])."', '".$this->dbEscapeString(@$_SERVER['HTTP_ACCEPT'])."', ";
-		$q .= "'".$this->dbEscapeString(@$_SERVER['HTTP_ACCEPT_CHARSET'])."', '".$this->dbEscapeString(@$_SERVER['HTTP_ACCEPT_ENCODING'])."', ";
+		$q .= "'".$this->dbEscapeString(isset($_SERVER['HTTP_REFERER']) ? $_SERVER['HTTP_REFERER'] : '')."', ";
+		$q .= "'".$this->dbEscapeString(isset($_SERVER['SCRIPT_FILENAME']) ? $_SERVER['SCRIPT_FILENAME'] : '')."', ";
+		$q .= "'".$this->dbEscapeString(isset($_SERVER['QUERY_STRING']) ? $_SERVER['QUERY_STRING'] : '')."', ";
+		$q .= "'".$this->dbEscapeString(isset($_SERVER['SERVER_NAME']) ? $_SERVER['SERVER_NAME'] : '')."', ";
+		$q .= "'".$this->dbEscapeString(isset($_SERVER['HTTP_HOST']) ? $_SERVER['HTTP_HOST'] : '')."', ";
+		$q .= "'".$this->dbEscapeString(isset($_SERVER['HTTP_ACCEPT']) ? $_SERVER['HTTP_ACCEPT'] : '')."', ";
+		$q .= "'".$this->dbEscapeString(isset($_SERVER['HTTP_ACCEPT_CHARSET']) ? $_SERVER['HTTP_ACCEPT_CHARSET'] : '')."', ";
+		$q .= "'".$this->dbEscapeString(isset($_SERVER['HTTP_ACCEPT_ENCODING']) ? $_SERVER['HTTP_ACCEPT_ENCODING'] : '')."', ";
 		$q .= "'".session_id()."', ";
-		$q .= "'".$this->dbEscapeString($this->action)."', '".$this->dbEscapeString($this->action_id)."', ";
-		$q .= "'".$this->dbEscapeString($this->action_yes)."', '".$this->dbEscapeString($this->action_flag)."', ";
-		$q .= "'".$this->dbEscapeString($this->action_menu)."', '".$this->dbEscapeString($this->action_loaded)."', ";
-		$q .= "'".$this->dbEscapeString($this->action_value)."', '".$this->dbEscapeString($this->action_error)."')";
+		$q .= "'".$this->dbEscapeString($this->action)."', ";
+		$q .= "'".$this->dbEscapeString($this->action_id)."', ";
+		$q .= "'".$this->dbEscapeString($this->action_yes)."', ";
+		$q .= "'".$this->dbEscapeString($this->action_flag)."', ";
+		$q .= "'".$this->dbEscapeString($this->action_menu)."', ";
+		$q .= "'".$this->dbEscapeString($this->action_loaded)."', ";
+		$q .= "'".$this->dbEscapeString($this->action_value)."', ";
+		$q .= "'".$this->dbEscapeString($this->action_error)."')";
 		$this->dbExec($q, 'NULL');
 	}

@@ -152,7 +174,7 @@ class Backend extends \CoreLibs\DB\IO
 	// PARAMS: level
 	// RETURN: returns an array for the top menu with all correct settings
 	// DESC  : menu creater
-	public function adbTopMenu($flag = 0)
+	public function adbTopMenu(int $flag = 0): array
 	{
 		if ($this->menu_show_flag) {
 			$flag = $this->menu_show_flag;
@@ -243,12 +265,12 @@ class Backend extends \CoreLibs\DB\IO
 	// PARAMS: filename
 	// RETURN: returns boolean true/false
 	// DESC  : checks if this filename is in the current situation (user id, etc) available
-	public function adbShowMenuPoint($filename)
+	public function adbShowMenuPoint(string $filename): bool
 	{
-		$enabled = 0;
+		$enabled = false;
 		switch ($filename) {
 			default:
-				$enabled = 1;
+				$enabled = true;
 				break;
 		};
 		return $enabled;
@@ -259,8 +281,9 @@ class Backend extends \CoreLibs\DB\IO
 	// PARAMS: db array, key, value part
 	// RETURN: returns and associative array
 	// DESC  : creates out of a normal db_return array an assoc array
-	public function adbAssocArray($db_array, $key, $value)
+	public function adbAssocArray(array $db_array, $key, $value): array
 	{
+		trigger_error('Method '.__METHOD__.' is deprecated', E_USER_DEPRECATED);
 		return $this->genAssocArray($db_array, $key, $value);
 	}

@@ -269,8 +292,9 @@ class Backend extends \CoreLibs\DB\IO
 	// PARAMS: int
 	// RETURN: string
 	// DESC  : converts bytes into formated string with KB, MB, etc
-	public function adbByteStringFormat($number)
+	public function adbByteStringFormat($number): string
 	{
+		trigger_error('Method '.__METHOD__.' is deprecated', E_USER_DEPRECATED);
 		return $this->byteStringFormat($number);
 	}

@@ -286,6 +310,7 @@ class Backend extends \CoreLibs\DB\IO
 	// DESC  : converts picture to a thumbnail with max x and max y size
 	public function adbCreateThumbnail($pic, $size_x, $size_y, $dummy = false, $path = "", $cache = "")
 	{
+		trigger_error('Method '.__METHOD__.' is deprecated', E_USER_DEPRECATED);
 		return $this->createThumbnail($pic, $size_x, $size_y, $dummy, $path, $cache);
 	}

@@ -295,7 +320,7 @@ class Backend extends \CoreLibs\DB\IO
 	//         var array -> optional data for a possible printf formated msg
 	// RETURN: none
 	// DESC  : wrapper function to fill up the mssages array
-	public function adbMsg($level, $msg, $vars = array ())
+	public function adbMsg(string $level, string $msg, array $vars = array ()): void
 	{
 		if (!preg_match("/^info|warning|error$/", $level)) {
 			$level = "info";
@@ -328,8 +353,16 @@ class Backend extends \CoreLibs\DB\IO
 	//         file      -> string for special file copy actions; mostyle "test#live;..."
 	// RETURN: none
 	// DESC  : writes live queue
-	public function adbLiveQueue($queue_key, $type, $target, $data, $key_name, $key_value, $associate = null, $file = null)
-	{
+	public function adbLiveQueue(
+		$queue_key,
+		$type,
+		$target,
+		$data,
+		$key_name,
+		$key_value,
+		$associate = null,
+		$file = null
+	) {
 		$q = "INSERT INTO ".GLOBAL_DB_SCHEMA.".live_queue (";
 		$q .= "queue_key, key_value, key_name, type, target, data, group_key, action, associate, file";
 		$q .= ") VALUES (";
@@ -353,8 +386,16 @@ class Backend extends \CoreLibs\DB\IO
 	// DESC  : print the date/time drop downs, used in any queue/send/insert at date/time place
 	// NOTE  : Basic class holds exact the same, except the Year/Month/Day/etc strings
 	//         are translated in this call
-	public function adbPrintDateTime($year, $month, $day, $hour, $min, $suffix = '', $min_steps = 1, $name_pos_back = false)
-	{
+	public function adbPrintDateTime(
+		$year,
+		$month,
+		$day,
+		$hour,
+		$min,
+		string $suffix = '',
+		int $min_steps = 1,
+		bool $name_pos_back = false
+	) {
 		// get the build layout
 		$html_time = $this->printDateTime($year, $month, $day, $hour, $min, $suffix, $min_steps, $name_pos_back);
 		// translate the strings inside
--- a/www/lib/CoreLibs/Basic.inc
+++ b/www/lib/CoreLibs/Basic.inc
--- a/www/lib/CoreLibs/DB/Extended/ArrayIO.inc
+++ b/www/lib/CoreLibs/DB/Extended/ArrayIO.inc
@@ -19,6 +19,7 @@
 *   PRIVATE METHOD:S
 *
 * HISTORY:
+* 2019/9/11 (cs) error string 21->91, 22->92 for not overlapping with IO
 * 2005/07/07 (cs) updated array class for postgres: set 0 & NULL if int field given, insert uses () values () syntax
 * 2005/03/31 (cs) fixed the class call with all debug vars
 * 2003-03-10: error_ids where still wrong chagned 11->21 and 12->22
@@ -51,17 +52,17 @@ class ArrayIO extends \CoreLibs\DB\IO
 	// PARAMS: db_config -> db_io class init vars
 	//         table_array -> the array from the table
 	//         table_name -> name of the table (for the array)
-	//         db_debug -> turn on db_io debug output (DB_DEBUG as global var does the same)
+	//         set_control_flag -> set basic class set/get variable error flags
 	// RETURN: none
 	// DESC  : constructor for the array io class, set the
 	//         primary key name automatically (from array)
-	public function __construct($db_config, $table_array, $table_name, $debug = 0, $db_debug = 0, $echo = 1, $print = 0)
+	public function __construct(array $db_config, array $table_array, string $table_name, int $set_control_flag = 0)
 	{
 		// instance db_io class
-		parent::__construct($db_config, $debug, $db_debug, $echo, $print);
+		parent::__construct($db_config, $set_control_flag);
 		// more error vars for this class
-		$this->error_string['21'] = 'No Primary Key given';
-		$this->error_string['22'] = 'Could not run Array Query';
+		$this->error_string['91'] = 'No Primary Key given';
+		$this->error_string['92'] = 'Could not run Array Query';

 		$this->table_array = $table_array;
 		$this->table_name = $table_name;
@@ -75,12 +76,13 @@ class ArrayIO extends \CoreLibs\DB\IO
 			}
 		} // set pk_name IF table_array was given
 		// internal
-		$this->class_info['db_array_io'] = array(
+		$this->class_info['db_array_io'] = array (
 			'class_name' => 'DB Array IO',
 			'class_version' => '1.0.0',
 			'class_created' => '2002/12/17',
 			'class_author' => 'Clemens Schwaighofer'
 		);
+		// echo "CALSS INFO POST [A]: <pre>".print_r($this->class_info, true)."</pre><br>";
 	}

 	// deconstruktor
@@ -158,7 +160,7 @@ class ArrayIO extends \CoreLibs\DB\IO
 		// if not set ... produce error
 		if (!$this->table_array[$this->pk_name]['value']) {
 			// if no PK found, error ...
-			$this->error_id = 21;
+			$this->error_id = 91;
 			$this->__dbError();
 			return 0;
 		} else {
@@ -234,7 +236,7 @@ class ArrayIO extends \CoreLibs\DB\IO
 		// if 0, error
 		unset($this->pk_id);
 		if (!$this->dbExec($q)) {
-			$this->error_id=22;
+			$this->error_id = 92;
 			$this->__dbError();
 		}
 		return $this->table_array;
@@ -306,7 +308,7 @@ class ArrayIO extends \CoreLibs\DB\IO
 			// possible dbFetchArray errors ...
 			$this->pk_id = $this->table_array[$this->pk_name]['value'];
 		} else {
-			$this->error_id = 22;
+			$this->error_id = 92;
 			$this->__dbError();
 		}
 		return $this->table_array;
@@ -514,7 +516,7 @@ class ArrayIO extends \CoreLibs\DB\IO
 		}
 		// return success or not
 		if (!$this->dbExec($q)) {
-			$this->error_id = 22;
+			$this->error_id = 92;
 			$this->__dbError();
 		}
 		// set primary key
--- a/www/lib/CoreLibs/DB/IO.inc
+++ b/www/lib/CoreLibs/DB/IO.inc
@@ -270,14 +270,16 @@ class IO extends \CoreLibs\Basic
 	public $cursor; // actual cursor (DBH)
 	public $num_rows; // how many rows have been found
 	public $num_fields; // how many fields has the query
-	public $field_names; // array with the field names of the current query
+	public $field_names = array (); // array with the field names of the current query
 	public $insert_id; // last inserted ID
 	public $insert_id_ext; // extended insert ID (for data outside only primary key)
+	private $temp_sql;
 	// other vars
 	private $nbsp = ''; // used by print_array recursion function
 	// error & warning id
 	private $error_id;
 	private $warning_id;
+	private $had_warning;
 	// sub include with the database functions
 	private $db_functions;

@@ -285,7 +287,7 @@ class IO extends \CoreLibs\Basic
 	private $MAX_QUERY_CALL;
 	private $query_called = array ();
 	// error string
-	private $error_string = array ();
+	protected $error_string = array ();
 	// prepared list
 	public $prepare_cursor = array ();
 	// primary key per table list
@@ -300,14 +302,13 @@ class IO extends \CoreLibs\Basic

 	// METHOD __construct
 	// PARAMS db_config -> array with db, user, password & host
-	//        debug -> turns debugging output on or of (default 0),
-	//        debugging can also be triggerd via DB_DEBUG var on global level
+	//        set_control_flag -> flags for core class get/set variable error handling
 	// RETURN nothing
 	// DESC   constructor for db_clss
-	public function __construct($db_config, $debug = 0, $db_debug = 0, $echo = 1, $print = 0)
+	public function __construct(array $db_config, int $set_control_flag = 0)
 	{
 		// start basic class
-		parent::__construct($debug, $echo, $print);
+		parent::__construct($set_control_flag);
 		// dummy init array for db config if not array
 		if (!is_array($db_config)) {
 			$db_config = array ();
@@ -355,7 +356,7 @@ class IO extends \CoreLibs\Basic
 		$this->error_string['42'] = 'Cannot check for async query, none has been started yet.';

 		// set debug, either via global var, or debug var during call
-		$this->db_debug = $db_debug;
+		$this->db_debug = false;
 		// global overrules local
 		if (isset($GLOBALS['DB_DEBUG'])) {
 			$this->db_debug = $GLOBALS['DB_DEBUG'];
@@ -389,7 +390,7 @@ class IO extends \CoreLibs\Basic
 			'class_author' => 'Clemens Schwaighofer'
 		);

-		// all ok return true
+		// so we can check that we have a successful DB connection created
 		return true;
 	}

@@ -414,7 +415,7 @@ class IO extends \CoreLibs\Basic
 	// DESC  :
 	// internal connection function. Used to connect to the DB if there is no connection done yet.
 	// Called before any execute
-	private function __connectToDB()
+	private function __connectToDB(): bool
 	{
 		// generate connect string
 		$this->dbh = $this->db_functions->__dbConnect($this->db_host, $this->db_user, $this->db_pwd, $this->db_name, $this->db_port, $this->db_ssl);
@@ -449,7 +450,7 @@ class IO extends \CoreLibs\Basic
 	// RETURN: none
 	// DESC  : close db connection
 	//         only used by the deconstructor
-	private function __closeDB()
+	private function __closeDB(): void
 	{
 		if (isset($this->dbh) && $this->dbh) {
 			$this->db_functions->__dbClose();
@@ -463,7 +464,7 @@ class IO extends \CoreLibs\Basic
 	// RETURN: true if matching, false if not
 	// DESC  : checks if query is a SELECT, SHOW or WITH, if not error, 0 return
 	// NOTE  : Query needs to start with SELECT, SHOW or WITH. if starts with "with" it is ignored
-	private function __checkQueryForSelect($query)
+	private function __checkQueryForSelect(string $query): bool
 	{
 		// perhaps allow spaces before select ?!?
 		if (preg_match("/^(select|show|with) /i", $query)) {
@@ -479,7 +480,7 @@ class IO extends \CoreLibs\Basic
 	// DESC  : check for DELETE, INSERT, UPDATE
 	//       : if pure is set to true, only when INSERT is set will return true
 	// NOTE  : Queries need to start with INSERT, UPDATE, DELETE. Anything else is ignored
-	private function __checkQueryForInsert($query, $pure = false)
+	private function __checkQueryForInsert(string $query, bool $pure = false): bool
 	{
 		if ($pure && preg_match("/^insert /i", $query)) {
 			return true;
@@ -495,7 +496,7 @@ class IO extends \CoreLibs\Basic
 	// RETURN: true if UPDATE, else false
 	// DESC  : returns true if the query starts with UPDATE
 	// NOTE  : query NEEDS to start with UPDATE
-	private function __checkQueryForUpdate($query)
+	private function __checkQueryForUpdate(string $query): bool
 	{
 		if (preg_match("/^update /i", $query)) {
 			return true;
@@ -509,9 +510,12 @@ class IO extends \CoreLibs\Basic
 	// RETURN: string with printed and formated array
 	// DESC  : internal funktion that creates the array
 	// NOTE  : used in db_dump_data only
-	private function __printArray($array)
+	private function __printArray(array $array): string
 	{
 		$string = '';
+		if (!is_array($array)) {
+			$array = array ();
+		}
 		foreach ($array as $key => $value) {
 			$string .= $this->nbsp.'<b>'.$key.'</b> => ';
 			if (is_array($value)) {
@@ -534,7 +538,7 @@ class IO extends \CoreLibs\Basic
 	//         type -> query identifiery (Q, I, etc)
 	// RETURN: none
 	// DESC  : calls the basic class debug with strip command
-	private function __dbDebug($debug_id, $error_string, $id = '', $type = '')
+	private function __dbDebug(string $debug_id, string $error_string, string $id = '', string $type = ''): void
 	{
 		$prefix = '';
 		if ($id) {
@@ -557,7 +561,7 @@ class IO extends \CoreLibs\Basic
 	// RETURN: none
 	// DESC  : if error_id set, writes long error string into error_msg
 	// NOTE  : needed to make public so it can be called from DB.Array.IO too
-	public function __dbError($cursor = '', $msg = '')
+	public function __dbError($cursor = '', string $msg = ''): void
 	{
 		$pg_error_string = '';
 		$where_called = $this->getCallerMethod();
@@ -591,15 +595,15 @@ class IO extends \CoreLibs\Basic
 	// PARAMS: array from fetch_row
 	// RETURN: convert fetch_row array
 	// DESC  : if there is the 'to_encoding' var set, and the field is in the wrong encoding converts it to the target
-	private function __dbConvertEncoding($row)
+	private function __dbConvertEncoding(array $row): array
 	{
 		if ($this->to_encoding && $this->db_encoding) {
 			// go through each row and convert the encoding if needed
-			for ($i = 0; $i < $this->num_fields; $i ++) {
-				$from_encoding = mb_detect_encoding($row[$i]);
+			foreach ($row as $key => $value) {
+				$from_encoding = mb_detect_encoding($value);
 				// convert only if encoding doesn't match and source is not pure ASCII
 				if ($from_encoding != $this->to_encoding && $from_encoding != 'ASCII') {
-					$row[$i] = mb_convert_encoding($row[$i], $this->to_encoding, $from_encoding);
+					$row[$key] = mb_convert_encoding($value, $this->to_encoding, $from_encoding);
 				}
 			}
 		}
@@ -611,7 +615,7 @@ class IO extends \CoreLibs\Basic
 	// PARAMS: $stm_name, data array
 	// RETURN: query in prepared form
 	// DESC  : for debug purpose replaces $1, $2, etc with actual data
-	private function __dbDebugPrepare($stm_name, $data = array())
+	private function __dbDebugPrepare(string $stm_name, array $data = array()): string
 	{
 		// get the keys from data array
 		$keys = array_keys($data);
@@ -628,7 +632,7 @@ class IO extends \CoreLibs\Basic
 	// PARAMS: insert/select/update/delete query
 	// RETURN: array with schema and table
 	// DESC  : extracts schema and table from the query, if no schema returns just empty string
-	private function __dbReturnTable($query)
+	private function __dbReturnTable(string $query): array
 	{
 		if (preg_match("/^SELECT /i", $query)) {
 			preg_match("/ (FROM) (([\w_]+)\.)?([\w_]+) /i", $query, $matches);
@@ -649,7 +653,7 @@ class IO extends \CoreLibs\Basic
 	//         * checks for insert if returning is set/pk name
 	//         * sets internal md5 for query
 	//         * checks multiple call count
-	private function __dbPrepareExec($query, $pk_name)
+	private function __dbPrepareExec(string $query, string $pk_name)
 	{
 		// to either use the returning method or the guess method for getting primary keys
 		$this->returning_id = false;
@@ -741,7 +745,7 @@ class IO extends \CoreLibs\Basic
 	// PARAMS: none
 	// RETURN: true on success or false if an error occured
 	// DESC  : runs post execute for rows affected, field names, inserted primary key, etc
-	private function __dbPostExec()
+	private function __dbPostExec(): bool
 	{
 		// if FALSE returned, set error stuff
 		// if either the cursor is false
@@ -762,7 +766,7 @@ class IO extends \CoreLibs\Basic
 				// count the fields
 				$this->num_fields = $this->db_functions->__dbNumFields($this->cursor);
 				// set field names
-				unset($this->field_names);
+				$this->field_names = array ();
 				for ($i = 0; $i < $this->num_fields; $i ++) {
 					$this->field_names[] = $this->db_functions->__dbFieldName($this->cursor, $i);
 				}
@@ -1177,7 +1181,7 @@ class IO extends \CoreLibs\Basic
 	//         like num_rows, num_fields, etc depending on query
 	//         for INSERT INTO queries it is highly recommended to set the pk_name to avoid an additional
 	//         read from the database for the PK NAME
-	public function dbExec($query = 0, $pk_name = '')
+	public function dbExec(string $query = '', string $pk_name = '')
 	{
 		// prepare and check if we can actually run it
 		if (($md5 = $this->__dbPrepareExec($query, $pk_name)) === false) {
@@ -1204,7 +1208,7 @@ class IO extends \CoreLibs\Basic
 	//         for INSERT INTO queries it is highly recommended to set the pk_name to avoid an additional
 	//         read from the database for the PK NAME
 	// NEEDS : dbCheckAsync
-	public function dbExecAsync($query, $pk_name = '')
+	public function dbExecAsync(string $query, string $pk_name = ''): bool
 	{
 		// prepare and check if we can actually run the query
 		if (($md5 = $this->__dbPrepareExec($query, $pk_name)) === false) {
@@ -1262,7 +1266,7 @@ class IO extends \CoreLibs\Basic
 	//         assoc_only -> false is default, if true only assoc rows
 	// RETURN: a mixed row
 	// DESC  : executes a cursor and returns the data, if no more data 0 will be returned
-	public function dbFetchArray($cursor = 0, $assoc_only = false)
+	public function dbFetchArray($cursor = 0, bool $assoc_only = false)
 	{
 		// return false if no query or cursor set ...
 		if (!$cursor) {
@@ -1287,7 +1291,7 @@ class IO extends \CoreLibs\Basic
 	//         assoc_only -> if true, only return assoc entry, else both (pgsql)
 	// RETURN: mixed db result
 	// DESC  : returns the FIRST row of the given query
-	public function dbReturnRow($query, $assoc_only = false)
+	public function dbReturnRow(string $query, bool $assoc_only = false)
 	{
 		if (!$query) {
 			$this->error_id = 11;
@@ -1311,7 +1315,7 @@ class IO extends \CoreLibs\Basic
 	//         assoc_only -> if true, only name ref are returned
 	// RETURN: array of hashes (row -> fields)
 	// DESC  : createds an array of hashes of the query (all data)
-	public function dbReturnArray($query, $assoc_only = false)
+	public function dbReturnArray(string $query, bool $assoc_only = false)
 	{
 		if (!$query) {
 			$this->error_id = 11;
@@ -1339,7 +1343,7 @@ class IO extends \CoreLibs\Basic
 	// PARAMS: $query -> query to find in cursor_ext
 	// RETURN: position (int)
 	// DESC  : returns the current position the read out
-	public function dbCursorPos($query)
+	public function dbCursorPos(string $query)
 	{
 		if (!$query) {
 			$this->error_id = 11;
@@ -1355,7 +1359,7 @@ class IO extends \CoreLibs\Basic
 	// PARAMS: $query -> query to find in cursor_ext
 	// RETURN: row count (int)
 	// DESC  : returns the number of rows for the current select query
-	public function dbCursorNumRows($query)
+	public function dbCursorNumRows(string $query)
 	{
 		if (!$query) {
 			$this->error_id = 11;
@@ -1370,9 +1374,9 @@ class IO extends \CoreLibs\Basic
 	// WAS   : db_show_table_meta_data
 	// PARAMS: $table -> table name
 	//         $schema -> optional schema name
-	// RETURN: array of table data
+	// RETURN: array of table data, false on error (table not found)
 	// DESC  : returns an array of the table with columns and values. FALSE on no table found
-	public function dbShowTableMetaData($table, $schema = '')
+	public function dbShowTableMetaData(string $table, string $schema = '')
 	{
 		$table = ($schema ? $schema.'.' : '').$table;

@@ -1386,11 +1390,11 @@ class IO extends \CoreLibs\Basic
 	// METHOD: dbPrepare
 	// WAS   : db_prepare
 	// PARAMS: $stm_name, $query, $pk_name: optional
-	// RETURN: false on error
+	// RETURN: false on error, true on warning or result on full ok
 	// DESC  : prepares a query
 	//         for INSERT INTO queries it is highly recommended to set the pk_name to avoid an additional
 	//         read from the database for the PK NAME
-	public function dbPrepare($stm_name, $query, $pk_name = '')
+	public function dbPrepare(string $stm_name, string $query, string $pk_name = '')
 	{
 		if (!$query) {
 			$this->error_id = 11;
@@ -1469,9 +1473,9 @@ class IO extends \CoreLibs\Basic
 	// METHOD: dbExecute
 	// WAS   : db_execute
 	// PARAMS: $stm_name, data array
-	// RETURN: false on error
+	// RETURN: false on error, result on OK
 	// DESC  : runs a prepare query
-	public function dbExecute($stm_name, $data = array())
+	public function dbExecute(string $stm_name, array $data = array())
 	{
 		// if we do not have no prepare cursor array entry for this statement name, abort
 		if (!is_array($this->prepare_cursor[$stm_name])) {
@@ -1492,22 +1496,25 @@ class IO extends \CoreLibs\Basic
 			if ($this->db_debug) {
 				$this->__dbDebug('db', $this->__dbDebugPrepare($stm_name, $data), 'dbExecPrep', 'Q');
 			}
-			$code = $this->db_functions->__dbExecute($stm_name, $data);
-			if (!$code) {
+			$result = $this->db_functions->__dbExecute($stm_name, $data);
+			if (!$result) {
 				$this->debug('ExecuteData', 'ERROR in STM['.$stm_name.'|'.$this->prepare_cursor[$stm_name]['result'].']: '.$this->print_ar($data));
 				$this->error_id = 22;
 				$this->__dbError($this->prepare_cursor[$stm_name]['result']);
 				$this->__dbDebug('db', '<span style="color: red;"><b>DB-Error</b> '.$stm_name.': Execution failed</span>', 'DB_ERROR');
+				return false;
 			}
-			if ($this->__checkQueryForInsert($this->prepare_cursor[$stm_name]['query'], true) && $this->prepare_cursor[$stm_name]['pk_name'] != 'NULL') {
+			if ($this->__checkQueryForInsert($this->prepare_cursor[$stm_name]['query'], true) &&
+				$this->prepare_cursor[$stm_name]['pk_name'] != 'NULL'
+			) {
 				if (!$this->prepare_cursor[$stm_name]['returning_id']) {
 					$this->insert_id = $this->db_functions->__dbInsertId($this->prepare_cursor[$stm_name]['query'], $this->prepare_cursor[$stm_name]['pk_name']);
-				} elseif ($code) {
+				} elseif ($result) {
 					$this->insert_id = array ();
 					$this->insert_id_ext = array ();
 					// we have returning, now we need to check if we get one or many returned
 					// we'll need to loop this, if we have multiple insert_id returns
-					while ($_insert_id = $this->db_functions->__dbFetchArray($code, PGSQL_ASSOC)) {
+					while ($_insert_id = $this->db_functions->__dbFetchArray($result, PGSQL_ASSOC)) {
 						$this->insert_id[] = $_insert_id;
 					}
 					// if we have only one, revert from arry to single
@@ -1517,7 +1524,9 @@ class IO extends \CoreLibs\Basic
 						// if this has only the pk_name, then only return this, else array of all data (but without the position)
 						// example if insert_id[0]['foo'] && insert_id[0]['bar'] it will become insert_id['foo'] & insert_id['bar']
 						// if only ['foo_id'] and it is the PK then the PK is directly written to the insert_id
-						if (count($this->insert_id[0]) > 1 || !array_key_exists($this->prepare_cursor[$stm_name]['pk_name'], $this->insert_id[0])) {
+						if (count($this->insert_id[0]) > 1 ||
+							!array_key_exists($this->prepare_cursor[$stm_name]['pk_name'], $this->insert_id[0])
+						) {
 							$this->insert_id_ext = $this->insert_id[0];
 							$this->insert_id = $this->insert_id[0][$this->prepare_cursor[$stm_name]['pk_name']];
 						} elseif ($this->insert_id[0][$this->prepare_cursor[$stm_name]['pk_name']]) {
@@ -1543,7 +1552,7 @@ class IO extends \CoreLibs\Basic
 					$this->__dbDebug('db', '<span style="color: orange;"><b>DB-Warning</b> '.$stm_name.': Could not get insert id</span>', 'DB_WARNING');
 				}
 			}
-			return $code;
+			return $result;
 		}
 	}

@@ -1552,7 +1561,7 @@ class IO extends \CoreLibs\Basic
 	// PARAMS: $string -> string to escape
 	// RETURN: escaped string
 	// DESC  : neutral function to escape a string for DB writing
-	public function dbEscapeString($string)
+	public function dbEscapeString(string $string): string
 	{
 		return $this->db_functions->__dbEscapeString($string);
 	}
@@ -1572,7 +1581,7 @@ class IO extends \CoreLibs\Basic
 	// PARAMS: none
 	// RETURN: database version as string
 	// DESC  : return current database version
-	public function dbVersion()
+	public function dbVersion(): string
 	{
 		return $this->db_functions->__dbVersion();
 	}
@@ -1583,7 +1592,7 @@ class IO extends \CoreLibs\Basic
 	//        =X.Y, >X.Y, <X.Y
 	// RETURN: true/false
 	// DESC  : returns boolean true or false if the string matches the database version
-	public function dbCompareVersion($compare)
+	public function dbCompareVersion(string $compare): bool
 	{
 		// compare has =, >, < prefix, and gets stripped, if the rest is not X.Y format then error
 		preg_match("/^([<>=]{1,})(\d{1,})\.(\d{1,})/", $compare, $matches);
@@ -1700,6 +1709,7 @@ class IO extends \CoreLibs\Basic
 	//                     -> alternate the primary key can be an array with
 	//                        'row' => 'row name', 'value' => 'data' to use a
 	//                        different column as the primary key
+	//                     !!! primary key can be an array or a number/string
 	//         table -> name for the target table
 	// (optional)
 	//         not_write_array -> list of elements not to write
@@ -1707,13 +1717,21 @@ class IO extends \CoreLibs\Basic
 	//         data -> optional array with data, if not _POST vars are used
 	// RETURN: primary key id
 	// DESC  : writes into one table based on array of table columns
-	public function dbWriteDataExt($write_array, $primary_key, $table, $not_write_array = array (), $not_write_update_array = array (), $data = array ())
-	{
+	public function dbWriteDataExt(
+		array $write_array,
+		$primary_key,
+		string $table,
+		array $not_write_array = array (),
+		array $not_write_update_array = array (),
+		array $data = array ()
+	) {
 		if (!is_array($primary_key)) {
 			$primary_key = array (
 				'row' => $table.'_id',
 				'value' => $primary_key
 			);
+		} elseif (!isset($primary_key['value'])) {
+			$primary_key['value'] = '';
 		}
 		// var set for strings
 		$q_sub_value = '';
@@ -1799,7 +1817,7 @@ class IO extends \CoreLibs\Basic
 	//         micro on off (default false)
 	// RETURN: Y/M/D/h/m/s formatted string (like TimeStringFormat
 	// DESC  :   only for postgres. pretty formats an age or datetime difference string
-	public function dbTimeFormat($age, $show_micro = false)
+	public function dbTimeFormat(string $age, bool $show_micro = false): string
 	{
 		// in string (datetime diff): 1786 days 22:11:52.87418
 		// or (age): 4 years 10 mons 21 days 12:31:11.87418
@@ -1821,7 +1839,7 @@ class IO extends \CoreLibs\Basic
 	// PARAMS: text: input text to parse to an array
 	// RETURN: PHP array of the parsed data
 	// DESC  : this is only needed for Postgresql. Converts postgresql arrays to PHP
-	public function dbArrayParse($text)
+	public function dbArrayParse(string $text): array
 	{
 		$output = array ();
 		return $this->db_functions->__dbArrayParse($text, $output);
@@ -1833,23 +1851,23 @@ class IO extends \CoreLibs\Basic
 	//          kbn -> escape trigger type
 	// RETURN: escaped value
 	// DESC  : clear up any data for valid DB insert
-	public function dbSqlEscape($value, $kbn = "")
+	public function dbSqlEscape($value, string $kbn = '')
 	{
 		switch ($kbn) {
-			case "i":
-				$value = (!isset($value) || $value === "") ? "NULL" : intval($value);
+			case 'i':
+				$value = (!isset($value) || $value === '') ? "NULL" : intval($value);
 				break;
-			case "f":
-				$value = (!isset($value) || $value === "") ? "NULL" : floatval($value);
+			case 'f':
+				$value = (!isset($value) || $value === '') ? "NULL" : floatval($value);
 				break;
-			case "t":
-				$value = (!isset($value) || $value === "") ? "NULL" : "'".$this->dbEscapeString($value)."'";
+			case 't':
+				$value = (!isset($value) || $value === '') ? "NULL" : "'".$this->dbEscapeString($value)."'";
 				break;
-			case "d":
-				$value = (!isset($value) || $value === "") ? "NULL" : "'".$this->dbEscapeString($value)."'";
+			case 'd':
+				$value = (!isset($value) || $value === '') ? "NULL" : "'".$this->dbEscapeString($value)."'";
 				break;
-			case "i2":
-				$value = (!isset($value) || $value === "") ? 0 : intval($value);
+			case 'i2':
+				$value = (!isset($value) || $value === '') ? 0 : intval($value);
 				break;
 		}
 		return $value;
@@ -2022,7 +2040,7 @@ class IO extends \CoreLibs\Basic
 		return $this->dbCacheReset($query);
 	}

-	public function db_exec($query = 0, $pk_name = '')
+	public function db_exec($query = '', $pk_name = '')
 	{
 		error_log('DEPRECATED CALL: '.__METHOD__.', '.__FILE__.':'.__LINE__.', '.debug_backtrace()[0]['file'].':'.debug_backtrace()[0]['line']);
 		trigger_error('Method '.__METHOD__.' is deprecated', E_USER_DEPRECATED);
@@ -2057,7 +2075,7 @@ class IO extends \CoreLibs\Basic
 		return $this->dbReturnRow($query);
 	}

-	public function db_return_array($query, $named_only = 0)
+	public function db_return_array($query, $named_only = false)
 	{
 		error_log('DEPRECATED CALL: '.__METHOD__.', '.__FILE__.':'.__LINE__.', '.debug_backtrace()[0]['file'].':'.debug_backtrace()[0]['line']);
 		trigger_error('Method '.__METHOD__.' is deprecated', E_USER_DEPRECATED);
--- a/www/lib/CoreLibs/Language/Core/GetTextReader.inc
+++ b/www/lib/CoreLibs/Language/Core/GetTextReader.inc
@@ -50,7 +50,7 @@ class GetTextReader
 	private $total = 0;          // total string count
 	private $table_originals = null;  // table for original strings (offsets)
 	private $table_translations = null;  // table for translated strings (offsets)
-	private $cache_translations = null;  // original -> translation mapping
+	private $cache_translations = array ();  // original -> translation mapping


 	/* Methods */
@@ -272,7 +272,7 @@ class GetTextReader

 		if ($this->enable_cache) {
 			// Caching enabled, get translated string from cache
-			if (array_key_exists($string, $this->cache_translations)) {
+			if (is_array($this->cache_translations) && array_key_exists($string, $this->cache_translations)) {
 				return $this->cache_translations[$string];
 			} else {
 				return $string;
@@ -355,7 +355,7 @@ class GetTextReader
 		// cache header field for plural forms
 		if (! is_string($this->pluralheader)) {
 			if ($this->enable_cache) {
-				$header = $this->cache_translations[""];
+				$header = $this->cache_translations[''];
 			} else {
 				$header = $this->get_translation_string(0);
 			}
@@ -415,7 +415,7 @@ class GetTextReader
 		$key = $single . chr(0) . $plural;

 		if ($this->enable_cache) {
-			if (! array_key_exists($key, $this->cache_translations)) {
+			if (is_array($this->cache_translations) && !array_key_exists($key, $this->cache_translations)) {
 				return ($number != 1) ? $plural : $single;
 			} else {
 				$result = $this->cache_translations[$key];
--- a/www/lib/CoreLibs/Language/L10n.inc
+++ b/www/lib/CoreLibs/Language/L10n.inc
@@ -35,7 +35,7 @@ class L10n extends \CoreLibs\Basic
 	private $input;
 	private $l10n;

-	public function __construct($lang = '', $path = '')
+	public function __construct(string $lang = '', string $path = '')
 	{
 		if (!$lang) {
 			$this->lang = 'en';
@@ -60,7 +60,7 @@ class L10n extends \CoreLibs\Basic
 	}

 	// reloads the mofile, if the location of the lang file changes
-	public function l10nReloadMOfile($lang, $path = '')
+	public function l10nReloadMOfile(string $lang, string $path = ''): bool
 	{
 		$success = false;
 		$old_mofile = $this->mofile;
--- a/www/lib/CoreLibs/Output/Form/Generate.inc
+++ b/www/lib/CoreLibs/Output/Form/Generate.inc
@@ -235,9 +235,10 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 	public $delete;
 	public $really_delete;
 	public $save;
+	public $remove_button;
 	// security publics
 	public $base_acl_level;
-	public $security_levels;
+	public $security_level;
 	// layout publics
 	public $table_width;

@@ -248,8 +249,8 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 	// PARAMS: $db_config -> connect to DB
 	//         $lang -> language code ('en', 'ja', etc)
 	//         $table_width -> width of table
-	//         $db_debug -> turns db_io debug on/off (DB_DEBUG as global var does the same)
-	public function __construct($db_config, $lang, $table_width = 750, $debug = 0, $db_debug = 0, $echo = 1, $print = 0)
+	//         $set_control_flag -> basic class set/get variable error flags
+	public function __construct(array $db_config, string $lang, int $table_width = 750, int $set_control_flag = 0)
 	{
 		$this->my_page_name = $this->getPageName(1);
 		// init the language class
@@ -278,7 +279,7 @@ class Generate extends \CoreLibs\DB\Extended\ArrayIO
 		}

 		// start the array_io class which will start db_io ...
-		parent::__construct($db_config, $config_array['table_array'], $config_array['table_name'], $debug, $db_debug, $echo, $print);
+		parent::__construct($db_config, $config_array['table_array'], $config_array['table_name'], $set_control_flag);
 		// here should be a check if the config_array is correct ...
 		if (isset($config_array['show_fields']) && is_array($config_array['show_fields'])) {
 			$this->field_array = $config_array['show_fields'];
--- a/www/lib/CoreLibs/Template/SmartyExtend.inc
+++ b/www/lib/CoreLibs/Template/SmartyExtend.inc
@@ -20,7 +20,7 @@ class SmartyExtend extends SmartyBC
 	public $l10n;

 	// constructor class, just sets the language stuff
-	public function __construct($lang)
+	public function __construct(string $lang)
 	{
 		SmartyBC::__construct();
 		$this->l10n = new \CoreLibs\Language\L10n($lang);