From e3306a096fd29e0d8a699db7f1375cc38e1d3d16 Mon Sep 17 00:00:00 2001
From: Clemens Schwaighofer <clemens.schwaighofer@omc.com>
Date: Thu, 25 Jun 2026 16:40:10 +0900
Subject: [PATCH] Tests updates: DB try catch for the ACL test, curl setup fix

curl init alone is not enought to validate a url.

for DB conneciton use try/catch to get errors and skip test
---
 4dev/tests/ACL/CoreLibsACLLoginTest.php       | 36 +++++++++++--------
 .../CoreLibsUrlRequestsCurlTest.php           |  4 +++
 2 files changed, 25 insertions(+), 15 deletions(-)

diff --git a/4dev/tests/ACL/CoreLibsACLLoginTest.php b/4dev/tests/ACL/CoreLibsACLLoginTest.php
index f29f02d7..f40bcc1d 100644
--- a/4dev/tests/ACL/CoreLibsACLLoginTest.php
+++ b/4dev/tests/ACL/CoreLibsACLLoginTest.php
@@ -80,21 +80,27 @@ final class CoreLibsACLLoginTest extends TestCase
 			'log_file_id' => 'CoreLibs-ACL-Login-Test',
 		]);
 		// test database we need to connect do, if not possible this test is skipped
-		self::$db = new \CoreLibs\DB\IO(
-			[
-				'db_name' => $db_name,
-				'db_user' => $db_user,
-				'db_pass' => $db_password,
-				'db_host' => $db_host,
-				'db_port' => 5432,
-				'db_schema' => 'public',
-				'db_type' => 'pgsql',
-				'db_encoding' => '',
-				'db_ssl' => 'allow', // allow, disable, require, prefer
-				'db_debug' => true,
-			],
-			self::$log
-		);
+		try {
+			self::$db = new \CoreLibs\DB\IO(
+				[
+					'db_name' => $db_name,
+					'db_user' => $db_user,
+					'db_pass' => $db_password,
+					'db_host' => $db_host,
+					'db_port' => 5432,
+					'db_schema' => 'public',
+					'db_type' => 'pgsql',
+					'db_encoding' => '',
+					'db_ssl' => 'allow', // allow, disable, require, prefer
+					'db_debug' => true,
+				],
+				self::$log
+			);
+		} catch (\Exception $e) {
+			self::markTestSkipped(
+				'Cannot connect to valid Test DB for ACL\Login test: ' . $e->getMessage()
+			);
+		}
 		// ALWAYS drop DB and RECREATE DB
 		// dropdb -U corelibs_acl_login_test -h localhost corelibs_acl_login_test
 		// createdb -U corelibs_acl_login_test -O corelibs_acl_login_test -E utf8 corelibs_acl_login_test;
diff --git a/4dev/tests/UrlRequests/CoreLibsUrlRequestsCurlTest.php b/4dev/tests/UrlRequests/CoreLibsUrlRequestsCurlTest.php
index 75c7a14c..7171fe0f 100644
--- a/4dev/tests/UrlRequests/CoreLibsUrlRequestsCurlTest.php
+++ b/4dev/tests/UrlRequests/CoreLibsUrlRequestsCurlTest.php
@@ -58,6 +58,10 @@ final class CoreLibsUrlRequestsCurlTest extends TestCase
 			if ($handle === false) {
 				continue;
 			}
+			$status = curl_exec($handle);
+			if ($status === false) {
+				continue;
+			}
 			$this->url_basic = $url;
 			// print "Open: $url\n";
 			break;