diff --git a/www/admin/class_test.datetime.php b/www/admin/class_test.datetime.php
index 45bca5e8..54633004 100644
--- a/www/admin/class_test.datetime.php
+++ b/www/admin/class_test.datetime.php
@@ -473,7 +473,10 @@ function intervalStringFormatDeprecated(
// print "-> V: $value | $part, $time_name | I: " . is_int($value) . " | F: " . is_float($value)
// . " | " . ($value != 0 ? 'Not zero' : 'ZERO') . "
";
// var_dump($skip_last_zero);
- if ($value != 0 || $skip_zero === false || $skip_last_zero === false) {
+ if (
+ is_numeric($value) &&
+ ($value != 0 || $skip_zero === false || $skip_last_zero === false)
+ ) {
if ($part == 'f') {
if ($truncate_nanoseconds === true) {
$value = round($value, 3);
diff --git a/www/admin/class_test.db.php b/www/admin/class_test.db.php
index a5537600..4a7676e7 100644
--- a/www/admin/class_test.db.php
+++ b/www/admin/class_test.db.php
@@ -76,41 +76,41 @@ $db->dbResetEncoding();
// empty calls, none of the below should fail
//
-$db->dbGetCursor();
+$foo = $db->dbGetCursor();
//
-$db->dbGetCursorExt();
+$foo = $db->dbGetCursorExt();
//
-$db->dbGetCursorPos('SELECT foo', ['bar']);
+$foo = $db->dbGetCursorPos('SELECT foo', ['bar']);
//
-$db->dbGetCursorNumRows('SELECT foo', ['bar']);
+$foo = $db->dbGetCursorNumRows('SELECT foo', ['bar']);
//
-$db->dbGetInsertPKName();
+$foo = $db->dbGetInsertPKName();
//
-$db->dbGetInsertPK();
+$foo = $db->dbGetInsertPK();
//
-$db->dbGetReturningExt();
-$db->dbGetReturningExt('foo');
-$db->dbGetReturningExt('foo', 0);
-$db->dbGetReturningExt(pos:0);
+$foo = $db->dbGetReturningExt();
+$foo = $db->dbGetReturningExt('foo');
+$foo = $db->dbGetReturningExt('foo', 0);
+$foo = $db->dbGetReturningExt(pos:0);
//
-$db->dbGetReturningArray();
+$foo = $db->dbGetReturningArray();
//
-$db->dbGetNumRows();
+$foo = $db->dbGetNumRows();
//
-$db->dbGetNumFields();
+$foo = $db->dbGetNumFields();
//
-$db->dbGetFieldNames();
+$foo = $db->dbGetFieldNames();
//
-$db->dbGetFieldTypes();
+$foo = $db->dbGetFieldTypes();
//
-$db->dbGetFieldNameTypes();
+$foo = $db->dbGetFieldNameTypes();
//
-$db->dbGetFieldName(0);
+$foo = $db->dbGetFieldName(0);
//
-$db->dbGetFieldType(0);
-$db->dbGetFieldType('foo');
+$foo = $db->dbGetFieldType(0);
+$foo = $db->dbGetFieldType('foo');
//
-$db->dbGetPrepareCursorValue('foo', 'bar');
+$foo = $db->dbGetPrepareCursorValue('foo', 'bar');
// TEST CACHE READS
diff --git a/www/admin/class_test.session.php b/www/admin/class_test.session.php
index eb73256d..139e6a80 100644
--- a/www/admin/class_test.session.php
+++ b/www/admin/class_test.session.php
@@ -86,8 +86,10 @@ if (!isset($_SESSION['counter'])) {
$_SESSION['counter']++;
print "[READ] A " . $var . ": " . ($_SESSION[$var] ?? '{UNSET}') . "
";
$_SESSION[$var] = $value;
+/** @phpstan-ignore-next-line nullCoalesce.offset */
print "[READ] B " . $var . ": " . ($_SESSION[$var] ?? '{UNSET}') . "
";
print "[READ] Confirm " . $var . " is " . $value . ": "
+/** @phpstan-ignore-next-line equal.alwaysTrue, nullCoalesce.offset */
. (($_SESSION[$var] ?? '') == $value ? 'Matching' : 'Not matching') . "
";
// test set wrappers methods
diff --git a/www/lib/CoreLibs/Combined/DateTime.php b/www/lib/CoreLibs/Combined/DateTime.php
index 89d1cd87..b86bdee2 100644
--- a/www/lib/CoreLibs/Combined/DateTime.php
+++ b/www/lib/CoreLibs/Combined/DateTime.php
@@ -737,10 +737,10 @@ class DateTime
$exclude_start_date
);
return [
- $values[0],
- $values[1],
- $values[2],
- $values[3],
+ $values[0] ?? 0,
+ $values[1] ?? 0,
+ $values[2] ?? 0,
+ $values[3] ?? false,
];
}
@@ -767,10 +767,10 @@ class DateTime
$exclude_start_date
);
return [
- 'overall' => $values['overall'],
- 'weekday' => $values['weekday'],
- 'weekend' => $values['weekend'],
- 'reverse' => $values['reverse'],
+ 'overall' => $values['overall'] ?? 0,
+ 'weekday' => $values['weekday'] ?? 0,
+ 'weekend' => $values['weekend'] ?? 0,
+ 'reverse' => $values['reverse'] ?? false,
];
}
diff --git a/www/lib/CoreLibs/Output/ProgressBar.php b/www/lib/CoreLibs/Output/ProgressBar.php
index 5c4f9c76..c64b6995 100644
--- a/www/lib/CoreLibs/Output/ProgressBar.php
+++ b/www/lib/CoreLibs/Output/ProgressBar.php
@@ -418,9 +418,7 @@ class ProgressBar
// if this is percent, we ignore anything, it is auto positioned
if ($this->label[$name]['type'] != 'percent') {
foreach (['top', 'left', 'width', 'height'] as $pos_name) {
- if ($$pos_name !== false) {
- $this->label[$name][$pos_name] = intval($$pos_name);
- }
+ $this->label[$name][$pos_name] = intval($$pos_name);
}
if ($align != '') {