From c830a3296238a41b844cb12f3c2c33f8214c9d96 Mon Sep 17 00:00:00 2001 From: Clemens Schwaighofer Date: Thu, 14 Apr 2022 13:43:26 +0900 Subject: [PATCH] Minor fix in gettext loop for max string lenght --- www/lib/CoreLibs/Language/Core/GetTextReader.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/www/lib/CoreLibs/Language/Core/GetTextReader.php b/www/lib/CoreLibs/Language/Core/GetTextReader.php index f15576e4..cfa8e7c1 100644 --- a/www/lib/CoreLibs/Language/Core/GetTextReader.php +++ b/www/lib/CoreLibs/Language/Core/GetTextReader.php @@ -353,7 +353,8 @@ class GetTextReader $expr .= ';'; $res = ''; $p = 0; - for ($i = 0; $i < strlen($expr); $i++) { + $expr_len = strlen($expr); + for ($i = 0; $i < $expr_len; $i++) { $ch = $expr[$i]; switch ($ch) { case '?': @@ -433,6 +434,7 @@ class GetTextReader $total = 0; $plural = 0; + // FIXME use Symfony\Component\ExpressionLanguage\ExpressionLanguage or similar eval("$string"); /** @phpstan-ignore-next-line 0 >= 0 is always true*/ if ($plural >= $total) {