CoreLibs/development
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Updates based on latest phpstan run

Browse Source
This commit is contained in:
Clemens Schwaighofer
2022-09-02 17:00:22 +09:00
parent 1a6c65df0e
commit 4b3fbaa309
5 changed files with 18 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
www/lib/CoreLibs/DB/IO.php
View File

@@ -2580,9 +2580,9 @@ class IO
// loop through the write array and each field to build the query
foreach ($write_array as $field) {
if (
(empty($primary_key['value']) ||
(!empty($primary_key['value']) &&
!in_array($field, $not_write_update_array))
(
empty($primary_key['value']) ||
!in_array($field, $not_write_update_array)
) &&
!in_array($field, $not_write_array)
) {

2
www/lib/CoreLibs/Debug/Logging.php
View File

@@ -173,7 +173,7 @@ class Logging
// can be overridden with basicSetLogFileId later
if (!empty($this->options['file_id'])) {
$this->setLogId($this->options['file_id'] ?? '');
$this->setLogId($this->options['file_id']);
} elseif (!empty($GLOBALS['LOG_FILE_ID'])) {
// legacy flow, should be removed and only set via options
$this->setLogId($GLOBALS['LOG_FILE_ID']);

2
www/lib/CoreLibs/Template/SmartyExtend.php
View File

@@ -423,7 +423,7 @@ class SmartyExtend extends \Smarty
$this->DATA['ADMIN'] = $cms->acl['admin'] ?? 0;
// top menu
$this->DATA['nav_menu'] = $cms->adbTopMenu();
$this->DATA['nav_menu_count'] = is_array($this->DATA['nav_menu']) ? count($this->DATA['nav_menu']) : 0;
$this->DATA['nav_menu_count'] = count($this->DATA['nav_menu']);
// messages = ['msg' =>, 'class' => 'error/warning/...']
$this->DATA['messages'] = $cms->messages;
} else { /** @phpstan-ignore-line Because I assume object for phpstan */