HtmlBuilder: change all return error to Throw, update Element/StrinReplace

We do not return old style bool on error, we throw Exceptions: HtmlBuilderExcpetion

Element has more classes to set tag, id, etc with basic checks for valid data

String Replace to set strings is one array with key -> value entries

Errors thrown on index for element/replace blocks

4dev/tests/Template/CoreLibsTemplateHtmlBuilderBlockTest.php

@@ -22,6 +22,13 @@ final class CoreLibsTemplateHtmlBuilderBlockTest extends TestCase
 			Block::buildHtml($el)
 		);
 	}
+
+	// ael
+	// aelx|addSub
+	// resetSub
+	// acssel/rcssel/scssel
+	// buildHtml
+	// buildHtmlFromList|printHtmlFromArray
 }
 
 // __END__

4dev/tests/Template/CoreLibsTemplateHtmlBuilderElementTest.php

@@ -7,6 +7,7 @@ namespace tests;
 use PHPUnit\Framework\TestCase;
 use CoreLibs\Template\HtmlBuilder\Element;
 use CoreLibs\Template\HtmlBuilder\General\Error;
+use CoreLibs\Template\HtmlBuilder\General\HtmlBuilderExcpetion;
 
 /**
  * Test class for Template\HtmlBuilder\Element
@@ -204,6 +205,8 @@ final class CoreLibsTemplateHtmlBuilderElementTest extends TestCase
 			'nested build failed'
 		);
 		// this would create a loop, throws error
+		$this->expectException(HtmlBuilderExcpetion::class);
+		$this->expectExceptionMessage("Cannot assign Element to itself, this would create an infinite loop");
 		$el_sub->addSub($el_sub);
 		$this->assertEquals(
 			'<div id="sub-1"></div>',
@@ -218,7 +221,7 @@ final class CoreLibsTemplateHtmlBuilderElementTest extends TestCase
 			[[
 				'level' => 'Error',
 				'id' => '100',
-				'message' => 'Cannot assign Element, this would create a loop',
+				'message' => 'Cannot assign Element to itself, this would create an infinite loop',
 				'context' => ['tag' => 'div', 'id' => 'sub-1']
 			]],
 			Error::getMessages(),
@@ -287,11 +290,11 @@ final class CoreLibsTemplateHtmlBuilderElementTest extends TestCase
 	/**
 	 * Undocumented function
 	 *
-	 * @testdox test change content
+	 * @testdox test change tag/id/content
 	 *
 	 * @return void
 	 */
-	public function testChangeContent(): void
+	public function testChangeElementData(): void
 	{
 		$el = new Element('div', 'id', 'Content');
 		// content change
@@ -306,6 +309,30 @@ final class CoreLibsTemplateHtmlBuilderElementTest extends TestCase
 			$el->getContent(),
 			'changed content'
 		);
+
+		$this->assertEquals(
+			'div',
+			$el->getTag(),
+			'set tag'
+		);
+		$el->setTag('span');
+		$this->assertEquals(
+			'span',
+			$el->getTag(),
+			'changed tag'
+		);
+
+		$this->assertEquals(
+			'id',
+			$el->getId(),
+			'set id'
+		);
+		$el->setId('id-2');
+		$this->assertEquals(
+			'id-2',
+			$el->getId(),
+			'changed id'
+		);
 	}
 
 	/**
@@ -349,7 +376,15 @@ final class CoreLibsTemplateHtmlBuilderElementTest extends TestCase
 
 	// build output
 	// build from array list
-	public function testBuildHtml(): void
+
+	/**
+	 * Undocumented function
+	 *
+	 * @testdox build element tree from object
+	 *
+	 * @return void
+	 */
+	public function testBuildHtmlObject(): void
 	{
 		// build a simple block
 		// div -> div -> button
@@ -399,13 +434,36 @@ final class CoreLibsTemplateHtmlBuilderElementTest extends TestCase
 	/**
 	 * Undocumented function
 	 *
-	 * @testdox check for invalid tag detection
+	 * @testdox build elements from array list
+	 *
+	 * @return void
+	 */
+	public function testbuildHtmlArray(): void
+	{
+		$this->assertEquals(
+			'<div id="id-1">A</div>'
+			. '<div id="id-2">B</div>'
+			. '<div id="id-3">C</div>',
+			Element::buildHtmlFromList([
+				new Element('div', 'id-1', 'A'),
+				new Element('div', 'id-2', 'B'),
+				new Element('div', 'id-3', 'C'),
+			])
+		);
+	}
+
+	/**
+	 * Undocumented function
+	 *
+	 * @testdox check for invalid tag detection, possible invalid id, possible invalid css
 	 *
 	 * @return void
 	 */
 	public function testInvalidElement(): void
 	{
 		Error::resetMessages();
+		$this->expectException(HtmlBuilderExcpetion::class);
+		$this->expectExceptionMessage("Could not create Element");
 		$el = new Element('');
 		$this->assertTrue(
 			Error::hasError(),
@@ -422,6 +480,27 @@ final class CoreLibsTemplateHtmlBuilderElementTest extends TestCase
 			'check error message failed'
 		);
 
+		// if we set invalid tag
+		$el = new Element('div');
+		$this->expectException(HtmlBuilderExcpetion::class);
+		$this->expectExceptionMessage("Invalid or empty tag");
+		$el->setTag('123123');
+		$this->assertTrue(
+			Error::hasError(),
+			'failed to set error invalid tag detection'
+		);
+		$this->assertEquals(
+			[[
+				'level' => 'Error',
+				'id' => '201',
+				'message' => 'invalid or empty tag',
+				'context' => ['tag' => '']
+			]],
+			Error::getMessages(),
+			'check error message failed'
+		);
+
+
 		// invalid id (warning)
 		Error::resetMessages();
 		$el = new Element('div', '-$a15');

4dev/tests/Template/CoreLibsTemplateHtmlBuilderStringReplaceTest.php

@@ -39,15 +39,27 @@ HTML,
 			StringReplace::replaceData(
 				$html_block,
 				[
-					'ID', 'CSS', '{CONTENT}'
-				],
-				[
-					'block-id', join(',', ['blue', 'red']),
-					'Some content here<br>with bla bla inside'
+					'ID' => 'block-id',
+					'CSS' => join(',', ['blue', 'red']),
+					'{CONTENT}' => 'Some content here<br>with bla bla inside',
 				]
 			)
 		);
 	}
+
+	/**
+	 * Undocumented function
+	 *
+	 * @testdox replaceData error
+	 *
+	 * @return void
+	 */
+	/* public function testReplaceDataErrors(): void
+	{
+		$this->expectException(HtmlBuilderExcpetion::class);
+		$this->expectExceptionMessage("Replace and content array count differ");
+		StringReplace::replaceData('<span>{FOO}</span>', ['{FOO}', '{BAR}'], ['foo']);
+	} */
 }
 
 // __END__