CoreLibs/development
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

phpstan updates for Smarty move to composer package

Browse Source
This commit is contained in:
Clemens Schwaighofer
2023-02-22 06:42:53 +09:00
parent 47c4c5cb69
commit 16c3653cee
3 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
phpstan.neon
View File

@@ -5,6 +5,7 @@ parameters:
tmpDir: /tmp/phpstan-corelibs tmpDir: /tmp/phpstan-corelibs
level: 8 # max is now 9 level: 8 # max is now 9
checkMissingCallableSignature: true checkMissingCallableSignature: true
treatPhpDocTypesAsCertain: false
paths: paths:
- %currentWorkingDirectory%/www - %currentWorkingDirectory%/www
bootstrapFiles: bootstrapFiles:
@@ -12,14 +13,13 @@ parameters:
# - %currentWorkingDirectory%/www/lib/autoloader.php # - %currentWorkingDirectory%/www/lib/autoloader.php
- %currentWorkingDirectory%/www/vendor/autoload.php - %currentWorkingDirectory%/www/vendor/autoload.php
scanDirectories: scanDirectories:
- www/lib/Smarty - www/vendor
scanFiles: scanFiles:
- www/configs/config.php - www/configs/config.php
- www/configs/config.master.php - www/configs/config.master.php
# if composer.json autoloader defined, this is not needed # if composer.json autoloader defined, this is not needed
# - www/lib/autoloader.php # - www/lib/autoloader.php
- www/vendor/autoload.php - www/vendor/autoload.php
- www/lib/Smarty/Autoloader.php
excludePaths: excludePaths:
# do not check old qq file uploader tests # do not check old qq file uploader tests
- www/admin/qq_file_upload_*.php - www/admin/qq_file_upload_*.php
@@ -43,9 +43,6 @@ parameters:
- www/log - www/log
- www/media - www/media
- www/tmp - www/tmp
# external libs are not checked
- www/lib/Smarty/
- www/lib/smarty-*/
# ignore composer # ignore composer
- www/vendor - www/vendor
# ignore errores with # ignore errores with

2
www/lib/CoreLibs/DB/IO.php
View File

@@ -1851,7 +1851,6 @@ class IO
// if cursor exists ... // if cursor exists ...
if ($this->cursor_ext[$query_hash]['cursor']) { if ($this->cursor_ext[$query_hash]['cursor']) {
/** @phpstan-ignore-next-line claims this is always false, but can be true */
if ($first_call === true) { if ($first_call === true) {
$this->cursor_ext[$query_hash]['log'][] = 'First call'; $this->cursor_ext[$query_hash]['log'][] = 'First call';
// count the rows returned (if select) // count the rows returned (if select)
@@ -3048,7 +3047,6 @@ class IO
} else { } else {
// find in all inside the array // find in all inside the array
$__arr = array_column($this->insert_id_arr, $key); $__arr = array_column($this->insert_id_arr, $key);
/** @phpstan-ignore-next-line [Why is this always true?] */
if (count($__arr)) { if (count($__arr)) {
return $__arr; return $__arr;
} else { } else {

2
www/lib/CoreLibs/Template/SmartyExtend.php
View File

@@ -453,7 +453,7 @@ class SmartyExtend extends \Smarty
$this->DATA['nav_menu_count'] = count($this->DATA['nav_menu']); $this->DATA['nav_menu_count'] = count($this->DATA['nav_menu']);
// messages = ['msg' =>, 'class' => 'error/warning/...'] // messages = ['msg' =>, 'class' => 'error/warning/...']
$this->DATA['messages'] = $cms->messages; $this->DATA['messages'] = $cms->messages;
} else { /** @phpstan-ignore-line Because I assume object for phpstan */ } else {
$this->DATA['show_ea_extra'] = false; $this->DATA['show_ea_extra'] = false;
$this->DATA['ADMIN'] = 0; $this->DATA['ADMIN'] = 0;
$this->DATA['nav_menu'] = []; $this->DATA['nav_menu'] = [];